Comments (4)
The first one is consistent with a regular "and", for which intersection is a good representation of what "must" be true about what's going on
if (isString(arg)) {
if (typeof arg === 'string') {
const z = arg;
// ^?
}
}
The second one... I don't know what to make of this. It's possible for a string
to end up there; the handling of this situation seems correct.
const s1: {} = "";
const s: Record<string, number> = s1;
t2(s);
from typescript.
The first one is wrong without the 2nd part of the condition too (and in your case too). Here without the 2nd part of the condition, it's not correctly report type of "z"
function t1(arg: Record<string, number>|number): string {
if ( isString(arg) === false ) {
const y = arg;
return '';
}
const z = arg; // should be "never"
return '';
}
This should work and "z" be never or it reported as unreachable.
The second one
Fair enough, this empty object issue is another unrelated issue that has been discussed here widely already, so not going to do that again here :)
So the 1st case is left as an issue?
from typescript.
z
isn't unreachable in legal code, though.
const n1 = "hello";
const n2: { length: number } = n1;
const n3: Record<string, number> = n2;
t1(n3);
from typescript.
You're right, since {} is assignable to string confusingly... (e.g. using boolean|number then it works without errors)
Thanks for clarifying.
from typescript.
Related Issues (20)
- [ServerErrors][TypeScript] 5.5.0-dev.20240421 HOT 14
- [ServerErrors][JavaScript] 5.5.0-dev.20240421 HOT 8
- `T extends infer I1 extends { K: infer I2 }` infers I2 to unknown HOT 6
- Wrong type narrowing on union type. HOT 2
- Document link for reference types and path
- object with `?:` property type, spread last --> allowed (but shouldn't) HOT 3
- Add a flag to require JS object literals to be initialized with all declared members HOT 4
- Type inference lost after spreading array with `ArrayLike` HOT 1
- Regular Expression finds HOT 4
- "This comparison appears to be unintentional" and control flow analysis with a variable updated in lambda HOT 4
- Classes static generic function return `any` type. HOT 2
- Is assignment not allowed here? HOT 2
- Editor changes overload resolution based on syntax HOT 5
- TS cache corruption leads to "error TS2590: Expression produces a union type that is too complex to represent" HOT 1
- Type alias circularly references itself (5.4 regression) HOT 1
- error TS2385: Overload signatures must all be public, private or protected. HOT 2
- `export type * ...` statements in `.d.ts` files do not work (5.4 regression) HOT 4
- HTMLFormElement disallows symbol keys HOT 5
- TypeScript language service cannot find subclass references/implementation of mixin methods
- when using ts.getJSDocTags, the value of @type is not returned. Is there any solution? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typescript.