Git Product home page Git Product logo

Comments (10)

jasonwilliams avatar jasonwilliams commented on July 28, 2024 2

So basically this repo isn't maintained by Microsoft anymore and needs to be forked and moved into the @styled organization. We should also update the dependencies while we're at it.

I don't have much time these days and don't know when i would get around to doing it. But that is the task.
As there's many issues cropping up about this issue I will try to see what I can do.

Once done i will need some people to test the changes have worked. I will also try to link this issue once we've migrated

from typescript-styled-plugin.

karlhorky avatar karlhorky commented on July 28, 2024

Seems like at least some of these would be resolved by running npm run update-data in vscode-css-languageservice, as mentioned here:

from typescript-styled-plugin.

karlhorky avatar karlhorky commented on July 28, 2024

Now that microsoft/vscode-css-languageservice#319 is merged, maybe this new version 6.2.1 will trickle in to typescript-styled-plugin at some point!

Edit: Oh, it seems like vscode-css-languageservice is stuck on an old version, can this be updated?

"vscode-css-languageservice": "^5.1.4",

cc @mjbvz @jasonwilliams

from typescript-styled-plugin.

jasonwilliams avatar jasonwilliams commented on July 28, 2024

@karlhorky are you on the styled components discord? Could you ping me there if so

from typescript-styled-plugin.

karlhorky avatar karlhorky commented on July 28, 2024

Ok great, are @probablyup or other Styled Components maintainers available to help with any of this migration? Maybe even Emotion maintainers like @emmatown or @Andarist would be able to lend a hand, since this tooling also directly benefits Emotion users.

I can probably devote a bit of time to testing extension updates 👍

from typescript-styled-plugin.

jasonwilliams avatar jasonwilliams commented on July 28, 2024

2 things..

  1. There's a pre-release version here https://marketplace.visualstudio.com/items?itemName=styled-components.vscode-styled-components 1.7.6. This uses the latest version of css language server. However, i don't know if all of those properties will work. I didn't have them working when using the latest version.
  2. Please feedback in https://github.com/styled-components/typescript-styled-plugin as this has now been forked and used in 1.7.6

from typescript-styled-plugin.

karlhorky avatar karlhorky commented on July 28, 2024

Ok, I'll test this, and reply with my feedback in this PR (at least this looks like the correct place 🤔):

from typescript-styled-plugin.

karlhorky avatar karlhorky commented on July 28, 2024

Just copying part of my comment over here for visibility:

Seems like this is actually fixed in the normal release version of [email protected] already, when using VS Code 1.74.0 (the error + warning below is actually a real typo, just to test that the error checking is working):

Screenshot 2022-12-09 at 18 06 40

from typescript-styled-plugin.

karlhorky avatar karlhorky commented on July 28, 2024

Ran into the problem with a different CSS property just now - accent-color doesn't appear to work, in either the normal [email protected] Release version or the [email protected] Pre-Release version (see below).

Maybe the property is too new and not yet in the vscode-css-languageservice data?

The error message is "Unknown property: 'accent-color".

Screenshot 2022-12-14 at 16 39 17

Screenshot 2022-12-14 at 16 38 50

from typescript-styled-plugin.

mjbvz avatar mjbvz commented on July 28, 2024

Closing as this package has been deprecated in favor of the official styled-components/typescript-styled-plugin fork

After updating to that fork, follow up in the styled-components repo if this is still an issue

from typescript-styled-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.