Git Product home page Git Product logo

Comments (3)

JiuqingSong avatar JiuqingSong commented on September 1, 2024

It is from

Instead of using view port width, we can use client width of editor. @juliaroldi can you take a look? BTW, can you remind me why we change from 100% to view port width?

from roosterjs.

juliaroldi avatar juliaroldi commented on September 1, 2024

It is from

Instead of using view port width, we can use client width of editor. @juliaroldi can you take a look? BTW, can you remind me why we change from 100% to view port width?

I think it is related to this change https://github.com/microsoft/roosterjs/pull/2126/files. If the image is too tall, it is not possible to resize or crop the image. Since we are not using this code for adjusting the height, should adjust the image with 100% width?

from roosterjs.

JiuqingSong avatar JiuqingSong commented on September 1, 2024

It is from

Instead of using view port width, we can use client width of editor. @juliaroldi can you take a look? BTW, can you remind me why we change from 100% to view port width?

I think it is related to this change https://github.com/microsoft/roosterjs/pull/2126/files. If the image is too tall, it is not possible to resize or crop the image. Since we are not using this code for adjusting the height, should adjust the image with 100% width?

We used 100% before, but for some reason we changed it. Will the original problem come back if we go back to 100%?

from roosterjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.