Fail fast on invalid rename, i.e do not show the input box asking for new symbol name about pylance-release HOT 7 CLOSED

Another case: no refactoring library is installed

from pylance-release.

Hi @mjbvz
Apologies for the late response. Unfortunately, I am not able to repro this behavior. For me, I get the error notification

Refactor failed. Rename refactoring should be performed on resolvable python identifiers. [<FrameSummary file refactor.py, line 382 in watch>, <FrameSummary file refactor.py, line 352 in _process_request>, <FrameSummary file refactor.py, line 260 in _rename>, <FrameSummary file refactor.py, line 129 in refactor>, <FrameSummary file refactor.py, line 156 in onRefactor>, <FrameSummary file c:\Users\karraj\Desktop\isort\.venv\lib\site-packages\rope\refactor\rename.py, line 28 in __init__>]

When trying to use F2 (Rename symbol command) on None.

Do you have the library rope is installed? Please send the python output channel and logs mentioned in the template.

from pylance-release.

Just to confirm: the bug is that it should fail as soon as you press f2; I should never see the input box in these cases because we know the rename operation will fail

from pylance-release.

I see, yes that's something we could improve.

from pylance-release.

Another case: no refactoring library is installed

ctags/rope is being removed in the 2021.10 release (#17225) so this is now stale.

from pylance-release.

This is still a issue with all language servers. Transferring to Pylance to see if it's possible.

from pylance-release.

This is #1418.

from pylance-release.