libzip-1.6.1-vs16-x64 ENABLE_LZMA about php-sdk-binary-tools HOT 4 CLOSED

Did you update the dependencies (phpsdk_deps -u)?

from php-sdk-binary-tools.

Did you update the dependencies (phpsdk_deps -u)?

My fault!!
Not with phpsdk_deps -u ; manually using https://windows.php.net/Downloads/php-sdk/deps/series/packages-master-vs16-x64-staging.txt and i just see that liblzma-5.2.5-vs16-x64.zip was added....
As I build some of the required deps, I didn't download all of them and my own "phpsdk_deps" script didn't look for new libs ^^
Fmi. did you build libzip lzma support with this patch:

diff --git "a/lib/zip_algorithm_xz.c" "b/lib/zip_algorithm_xz.c"
index 6dd14ce7..0492fc40 100644
--- "a/lib/zip_algorithm_xz.c"
+++ "b/lib/zip_algorithm_xz.c" 
@@ -36,6 +36,8 @@
 
 #include <limits.h>
 #include <stdlib.h>
+// https://github.com/ShiftMediaProject/liblzma/blob/master/windows/INSTALL-MSVC.txt
+#define LZMA_API_STATIC
 #include <lzma.h>
 
 struct ctx {

from php-sdk-binary-tools.

Fmi. did you build libzip lzma support with this patch:

libzip-1.6.1 has been build with winlibs/libzip@01b9721 (that macro has been defined by passing /D LZMA_API_STATIC to cl.exe).

from php-sdk-binary-tools.

Thanks!

from php-sdk-binary-tools.