Git Product home page Git Product logo

Comments (11)

jeffaco avatar jeffaco commented on September 2, 2024

To be clear: the installbuilder data files are within OMI. However, installbuilder itself lives in the PAL.

Personally, I don't think this is a big deal. You need some repo for InstallBuilder. Sure, we could put it in it's own repo, and you could use that. Or we could put it in the PAL, and you could use that. Given that you aren't using anything else from the PAL, I don't think this is a big deal, personally. Just use it from the PAL.

If we move it from the PAL (which we could do), that would require touching a bunch of different projects that use it (not meant to be complete, I might be forgetting something): SCXcore, Apache, MySQL, Docker, OMS, DSC, etc.

Is there a big problem where you can't just reference it from the PAL?

from omi.

andyleejordan avatar andyleejordan commented on September 2, 2024

If it lives in the PAL and requires the PAL, that's good enough.

from omi.

jeffaco avatar jeffaco commented on September 2, 2024

Installbuilder is standalone. We could move it elsewhere. But if we did, it would touch a lot of projects, as I said above. Installbuilder does not require the PAL, it just happens to live there.

Reference it from the PAL, you're good.

from omi.

andyleejordan avatar andyleejordan commented on September 2, 2024

This makes me want to lean toward the first alternative in #24, since packaging OMI will require pulling in another submodule.

from omi.

andyleejordan avatar andyleejordan commented on September 2, 2024

We've extracted InstallBuilder to PowerShell/InstallBuilder; how do build the OMI package?

from omi.

niroyb avatar niroyb commented on September 2, 2024

Taken from the SCX make steps:

========================= Make OMI installer RPM
sudo rm -rf /home/niroy/git/Build-SCXcore/omi/Unix/output/intermediate/staging
mkdir -p /home/niroy/git/Build-SCXcore/omi/Unix/output/release /home/niroy/git/Build-SCXcore/omi/Unix/output/intermediate
python /home/niroy/git/Build-SCXcore/omi/Unix/../../pal/installer/InstallBuilder/installbuilder.py \
        --BASE_DIR=/home/niroy/git/Build-SCXcore/omi/Unix/output \
        --TARGET_DIR=/home/niroy/git/Build-SCXcore/omi/Unix/output/release \
        --INTERMEDIATE_DIR=/home/niroy/git/Build-SCXcore/omi/Unix/output/intermediate \
        --STAGING_DIR=/home/niroy/git/Build-SCXcore/omi/Unix/output/intermediate/staging \
        --PF=Linux \
        --PFMAJOR=1 \
        --PFMINOR=0 \
        --PFARCH=x64 \
        --PFDISTRO=ULINUX \
        --VERSION=1.0.8 \
        --RELEASE=5 \
        --OUTPUTFILE=omi-1.0.8-5.universal.x64 \
        --DATAFILE_PATH=/home/niroy/git/Build-SCXcore/omi/Unix/installbuilder/datafiles \
        Base_OMI.data Linux.data Linux_RPM.data

Defined in
https://github.com/PowerShell/omi/blob/master/Unix/installbuilder/GNUmakefile

from omi.

jeffaco avatar jeffaco commented on September 2, 2024

I'm not wild on you extracting InstallBuilder to PowerShell; couldn't you just consume from the PAL?

The issue is that we recently found a bug (that will likely turn out to be in InstallBuilder), so when we find it, we'll fix it.

If you can't consume from the PAL, then just watch the PAL for changes, I guess. And eventually, push us to pull InstallBuilder into a separate repository. That will take us some time to do, but we can do it.

I know a lot about our build stuff, if you have issues building the package, let me know. The data files that OMI is using lives in omi/Unix/installbuilder/datafiles/.

from omi.

andyleejordan avatar andyleejordan commented on September 2, 2024

InstallBuilder fork is deleted.

@lilyfang, @paulcallen, @jeffaco per our earlier conversation, PSRP needs the following OMI 2.0 packages:

  • omi-server
  • omi-client
  • [omi-common]
  • omi-dev
  • omi-psrp

from omi.

jeffaco avatar jeffaco commented on September 2, 2024

These new packages are not difficult. The difficult part is determining EXACTLY what's in each package, and making sure we're not missing pieces, and capturing dependencies between packages properly..

We also need to determine how we build our stuff internally. Currently, we build our stuff by building OMI and then building things dependent on OMI. Will this still be the case? Or, as part of the build, will we be installing omi-dev and dependent packages? I tend to like the former, given that OMI can change a lot. But I can be persuaded ... 😄

from omi.

paulcallen avatar paulcallen commented on September 2, 2024

going to close this until we decide to resurrect this discussion.

from omi.

jeffaco avatar jeffaco commented on September 2, 2024

I didn't realize that there was an issue for this. I completed this work some time ago, but because I didn't realize there was an issue for it, I didn't close the issue:

jeffcof:omi> git --no-pager show --stat ed5607e
commit ed5607e
Author: Jeff Coffler <[email protected]>
Date:   Mon Nov 14 11:55:24 2016

    Add --enable-microsoft to configure, enable native installation kits

 Unix/build.mak                  |  87 +--------------
 Unix/configure                  | 228 ++++++++++++++++++++++++++++++----------
 Unix/installbuilder/GNUmakefile |   2 +-
 3 files changed, 179 insertions(+), 138 deletions(-)

These changes, assuming you're using the Build-omi superproject, will automatically build a package. These packages are used in dependent packages (like SCXcore, SCXcm, etc).

from omi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.