Clarification about "$/progress": replace or append? about language-server-protocol HOT 6 CLOSED

I would expect append behavior otherwise clients get 1+2+3+4+…+n = n(n+1)/2 = O(n^2) items to process.

from language-server-protocol.

The idea is an append behavior. Think about it as an async iterator where the '$/progress` event is the source of new async items.

from language-server-protocol.

Will update the spec to make this clear.

from language-server-protocol.

The spec is ambiguous on this question:

If a server reports partial result via a corresponding $/progress, the whole result must be reported using n $/progress notifications. The final response has to be empty in terms of result values. This avoids confusion about how the final result should be interpreted, e.g. as another partial result or as a replacing result.

This makes it clear that the final result doesn't replace all the $/progress that came earlier, but we don't know whether each $/progress will replace all the $/progress that came earlier...

from language-server-protocol.

ping @dbaeumer, would love to get your answer on this. We've just finished implementing streaming textDocument/references results our Hack LSP server, using just small tweak in our extension to alter the VSCode find-references pane, but we need to decide on the LSP behavior.

from language-server-protocol.

Thank you!

from language-server-protocol.