Git Product home page Git Product logo

Comments (7)

ba11b0y avatar ba11b0y commented on August 25, 2024

@derekbekoe I would like to take this up.

from knack.

tjprescott avatar tjprescott commented on August 25, 2024

@invinciblycool that would be great!

from knack.

StingyJack avatar StingyJack commented on August 25, 2024

The library should honor the hosting console's (the user's preferences) display colors and not choose an arbitrary color.

This is an accessibility issue and should be given appropriate priority. It should really not be considered a feature request.

from knack.

StingyJack avatar StingyJack commented on August 25, 2024

I made this change to my local repo, but am not sure how to go about testing it where I want to see the change ultimately effected.
image

Is there a script that will make a locally usable knack that I can use in a local copy of azure-cli, that i can then build and run? Or should I just pip install the knack package into the azure-cli and edit there?

from knack.

tjprescott avatar tjprescott commented on August 25, 2024

If you have cloned the repo, you should be able to go to the root of that repo and run pip install -e <path to knack setup.py file> --ignore-installed.

The other option would be to modify the code in you virtual environment's site-packages folder where you have the CLI installed.

from knack.

atbagga avatar atbagga commented on August 25, 2024

@StingyJack Here is the difference in the two colors (LIGHTRED_EX on top, RED at bottom) on windows command prompt. I also tried on powershell and the LIGHTRED_EX seems much better in contrast.

image

from knack.

tjprescott avatar tjprescott commented on August 25, 2024

Fixed by PR #147.

from knack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.