Comments (7)
@derekbekoe I would like to take this up.
from knack.
@invinciblycool that would be great!
from knack.
The library should honor the hosting console's (the user's preferences) display colors and not choose an arbitrary color.
This is an accessibility issue and should be given appropriate priority. It should really not be considered a feature request.
from knack.
I made this change to my local repo, but am not sure how to go about testing it where I want to see the change ultimately effected.
Is there a script that will make a locally usable knack that I can use in a local copy of azure-cli, that i can then build and run? Or should I just pip install the knack package into the azure-cli and edit there?
from knack.
If you have cloned the repo, you should be able to go to the root of that repo and run pip install -e <path to knack setup.py file> --ignore-installed
.
The other option would be to modify the code in you virtual environment's site-packages folder where you have the CLI installed.
from knack.
@StingyJack Here is the difference in the two colors (LIGHTRED_EX on top, RED at bottom) on windows command prompt. I also tried on powershell and the LIGHTRED_EX seems much better in contrast.
from knack.
Fixed by PR #147.
from knack.
Related Issues (20)
- Best practice to read configuration values from whithin commands? HOT 1
- What is client_factory?
- util.todict process DefaultInt to a dictionary instead of a int HOT 1
- CLICommandsLoader.create_command overrides the argument "arguments_loader" HOT 3
- Release candidate tags are sorted as higher than actual releases (0.8.0rc2 >> 0.8.0) HOT 7
- TSV output doesn't include headers
- Misleading error message for invalid choice arguments
- Knack error when I run azdev linter
- How to disable default Global Arguments (especially -o)?
- When json value has null, knack in Azure CLI changes column order unintentionally. HOT 1
- Colorama is not being installed in Windows even though it is required
- I think Knack is pulling a version of PyYAML that has a known vulnerability. HOT 10
- Config file value ignored by command validation code HOT 1
- This repo is missing important files
- Set column width for tabular output format HOT 1
- Remove / move `ensure_dir` call since it might cause some issues and not consistent HOT 5
- `extract_full_summary_from_signature` uses undocumented `Match.regs`
- Inefficient regex in `extract_full_summary_from_signature`
- knack/knack /prompting.py _prompt_bool never taking default action
- Broken `examples/test_exapp`: TypeError: ScenarioTest.__init__() missing 1 required positional argument: 'method_name' HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from knack.