Comments (7)
This would also fix a related issue. In the screenshot below you can see the Dropdown inside of a container with overflow: hidden
set. The Dropdown is cut off, because it's contents haven't been lifted out via the LayerHost that Callout and other components use.
from fluentui.
Yes please.
from fluentui.
Micah - if you can find time for this, it's low hanging fruit!
from fluentui.
I actually already took a first crack at this. Let me see where it's at and push up a PR for review.
from fluentui.
#446 is my initial PR. I've moved over to using the callout, but there are several issues I still need to overcome.
- Because it is on a different layer, the width cannot be assumed. Need to determine best way to measure this.
- Due to multiple ways to close the dropdown (click on input and regular callout scroll/click outside etc) the dropdown isn't closing properly when you click the input box. Basically the callback fires before the click function has a chance to test "is-closed". Means you can't close it via click.
- More cleanup around the change of styling and functionality.
from fluentui.
I'm trying to wrap up the tooltip, so rather than going down this rabbit hole, I'm going to leave it here until I'm done. If someone else wants to finish up, feel free.
from fluentui.
This is now checked in.
from fluentui.
Related Issues (20)
- Root tree calls `onOpenChange` with `false` on every tree item click
- [Bug]: Typo in Stack section in React FluentUI documentation
- [Bug]: The latest version of `@fluentui/merge-styles` package is breaking. HOT 2
- [Bug]: Inconsistent Typography Font Weights in Fluent UI Implementation HOT 2
- Keytips HOT 1
- [Feature]: List View and Preview Dialog Functionality HOT 2
- ColorPicker HOT 1
- [Bug]: Fluent react v8 to v9 migration documentation out of date HOT 2
- [Feature]: Create theme with key color HOT 2
- [Feature]: ListItem onAction should pass value
- [Bug]: MenuButton transparent appearance styling not consistent when rendered within a Popover trigger element HOT 1
- [Bug]: react-dialog breaking changes to type of children HOT 3
- [Feature]: implement release pipeline and release group for projects tagged with `"tools"`
- [Feature]: project domain scoping/co-location
- [Bug]: [Accessibility] [combobox] [docsite]: Page is scroll into top when combobox is focused with TAB key HOT 2
- [Bug]: Contextual menu, clicking on check icon sometimes causes a dismiss rather than an onClick to uncheck the item
- [Bug]: v9 DatePicker compat popup is not accessible in latest Chromium
- [Bug]: ComboBox and TextField components shared the same autofill data. HOT 3
- [Bug]: [Screen reader]: Selected option name is included as part of the label for all the dropdowns HOT 1
- [Feature]: Show changelog directly in doc site
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fluentui.