Git Product home page Git Product logo

Comments (4)

kevicency avatar kevicency commented on May 21, 2024

@dzearing i can do a proposal if no one started working on this yet

from fluentui.

dzearing avatar dzearing commented on May 21, 2024

@kmees Sounds good!

Here are my notes on it:

First I wonder if we should really split out some root base atomic components with no fluff. InputText and TextArea maybe? They don't have a label or anything fancy; we may have InputType enum so that we can render the different variations.

For these atomic components, maybe THESE should be the ones that get the props mixed in, like you were advocating for. I very much would love to do this where it makes the most sense and is predictable.

For composite components like TextField, it would have a label + one of those atomic things. Useful for forms.

For validation scenarios we should have something like ValidatingTextField. Maybe this should be the promise based component. But even in its current state I think it's weird. The validation occurs by default behind a 250ms delay, which gives an unexpected delay, which i think is a totally unnecessary default behavior.

from fluentui.

kevicency avatar kevicency commented on May 21, 2024

What benefit does an InputText or TextArea component have over <input /> if there is no fluff? Some styles 'require' a label (i.e. underline) and I can't think of much other stuff to put into those atomic components.

I'll just tinker around a bit and do a PR with a proposal.

Also, what was the verdict on the rootProps discussion? I was on holiday and didn't really follow it.

from fluentui.

micahgodbolt avatar micahgodbolt commented on May 21, 2024

from #264 "I've merged some of the cleanup changes in this PR in a separate PR; super sorry we took so long to get to this. I'm going to close this PR as it hasn't been updated in a while and is a little outdated now."

from fluentui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.