Memory about fluentdarkmodekit HOT 11 CLOSED

i find that if i create image with UIGraphicsBeginImageContextWithOptions and register the image in to UIImageAsset, the memory will never release.

from fluentdarkmodekit.

Hi there. can you create a sample project and upload it here for us to test, that would make it easier for us to locate the issue.

from fluentdarkmodekit.

here is the demo : DYDemo2.zip

from fluentdarkmodekit.

Please follow the guide https://github.com/microsoft/FluentDarkModeKit#get-started to correctly set up FluentDarkModeKit before using it. (It might not be working with Objective-C as of now since the setup functions are swift only, but should be easy to change it to Obj-C compatible).

I tested with your project without using FluentDarkModeKit, replaced

UIImage *image = [UIImage dm_imageWithLightImage:lightImage darkImage:darkImage];
self.imageV.image = image;

with

self.imageV.image = lightImage;

there is still the memory growth that did not go down after going back to the first VC.

from fluentdarkmodekit.

if you use like this

self.imageV.image = lightImage;

the memory will grow up when went to second VC only on first time.

but, if use FluentDarkModeKit the memory will growth everytime when i go to second VC

from fluentdarkmodekit.

This is taken without using FluentDarkModeKit but the memory is increasing.

from fluentdarkmodekit.

oh, thank you, i find that the memory growth is bacause of "UIGraphicsBeginImageContextWithOptions" .

from fluentdarkmodekit.

hi, i tried like this, app memory are not increasing:

UIImage *darkImage = [[self class] image:lightImage byApplyingAlpha:0.5]; 
//UIImage *image = [UIImage dm_imageWithLightImage:lightImage darkImage:darkImage];  
self.imageV.image = lightImage;

from fluentdarkmodekit.

do you have any good advice?

from fluentdarkmodekit.

I think the question is out of the scope of current library. It's more of how your app manage images.

from fluentdarkmodekit.

it sounds like it is related to how UIKit manages image assets, so we cannot solve the issue where images are not released as a library.

But we do offer an option to not use image asset.

configuration.useImageAsset = false

Please see to the detail in get started section

from fluentdarkmodekit.