Comments (4)
I’m on the fence as to what to do here.
from flow2dts.
I recall that @TheSavior previously had mentioned that RN core is open to accepting patches to change code to use ES6 syntax, but that they simply hadn’t had a strong need to do so yet. Perhaps the Animated
APIs would be a good case to change upstream so that we don’t need to do any real conversions, but that means that for the time being we should perform that change in the TS typings with an override.
from flow2dts.
What would you propose the change to the upstream code looks like?
from flow2dts.
I decided to fix it in TS instead, seeing as namespaces are a TS only thing. d385982
from flow2dts.
Related Issues (20)
- ACTION REQUIRED: Microsoft needs this private repository to complete compliance info
- Migration path from current DefinitelyTyped RN typings HOT 6
- [need verification] Do `import typeof` right HOT 1
- Clean export HOT 1
- Port typings from DT to upstream RN Flow codebase.
- Keep `typeof` when getting types of a class' properties HOT 7
- [TS2322] Component class with wider defaultProps typing
- Difference between RN's and DT's SyntheticEvent type
- Don't store classes in intermediate variables HOT 1
- Make a decision on converting opaque type alias in Flow
- Diff between generated type descriptions and @types/react-native HOT 1
- Classes are not correctly exported in index.d.ts HOT 3
- Make a decision on converting "*" type alias in Flow
- Convert type alias to interface? HOT 1
- Import as if es6 module export from default exported object
- babel/parser can't parse restricted types HOT 1
- Upstream local patches
- Throw nicer errors from transforms
- Generate a hint file for identifiers for workbench input HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flow2dts.