Git Product home page Git Product logo

Comments (4)

jimmyca15 avatar jimmyca15 commented on May 17, 2024 2

To open back up the discussion to see if we can come up with a good approach we can build off what was proposed previously which was the following

services.AddSingleton<IFunctionality, SecretSaucev1>()  // v1 - this is the default version
        .OverrideForFeature<IFunctionality, SecretSaucev2>("NewEnhancedVersion") // v2 - this is the new version

I like this proposal by @philcarbone.

Consumption for this can be done through a service that is added into by the feature management package.

public interface IFeatureService<T>
{
  Task<T> GetValue<T>();
}

IFeatureService would evaluate the state of the "NewEnhancedVersion" and return which of the features should be returned based on the initial registration of features. This is **late binding**. It does not use the state of the feature during the call to Services.OverrideForFeatureit uses the state duringIFeatureService.GetValue()`. This allows dynamic change of implementation during lifetime of the application and even different implementation on different requests.

Here would be an example usage.

public class MyType
{
  private readonly IFeatureService<IFunctionality> _secretSauce

  public MyType(IFeatureService<IFunctionality> secretSauce)
  {
    _secretSauce = secretSauce.GetValue();
  }

  public async Task DoSomething()
  {
    IFunctionality secretSauce = await _secretSauce.GetValue();

    // Use it.
  }
}

from featuremanagement-dotnet.

SpaceOgre avatar SpaceOgre commented on May 17, 2024 2

Any news about this? Just came across this problem now and our solution atm is to inject all versions and the have a provider for each type. It would be nice if this library provided something for this out of the box.

from featuremanagement-dotnet.

zhiyuanliang-ms avatar zhiyuanliang-ms commented on May 17, 2024 1

@SpaceOgre #335 We are implementing the new feature called variant-based injection. Hopefully, this can go with the next preview release.

from featuremanagement-dotnet.

zhiyuanliang-ms avatar zhiyuanliang-ms commented on May 17, 2024

@SpaceOgre I noticed that in .NET 8, registering service with a key is possible. Maybe it would be helpful for your case.
https://devblogs.microsoft.com/dotnet/announcing-dotnet-8-preview-7/#keyed-services-support-in-microsoft-extensions-dependencyinjection

from featuremanagement-dotnet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.