Git Product home page Git Product logo

Comments (13)

ShreyasJejurkar avatar ShreyasJejurkar commented on May 18, 2024 1

@EisenbergEffect Yup.

@vnbaaij 's namespace PR - > moving it to razor.cs - > xml docs!

from fast-blazor.

EisenbergEffect avatar EisenbergEffect commented on May 18, 2024

This sounds like a a great improvement. We'd love to have this as a community contribution 😄

from fast-blazor.

ShreyasJejurkar avatar ShreyasJejurkar commented on May 18, 2024

@EisenbergEffect Yes.
Can I know the place where we keep docs for FAST UI components so that I will try to match docs with their docs about each property and component so that it will be consistent for users!

from fast-blazor.

vnbaaij avatar vnbaaij commented on May 18, 2024

@ShreyasJejurkar
The official docs are here: https://docs.microsoft.com/en-us/fluent-ui/web-components/
The Fluent UI Web Components source is here: https://github.com/microsoft/fluentui/tree/master/packages/web-components. I would use the description fields from the xxx.vscode.definition.json files found in the web-components/src folder

from fast-blazor.

ShreyasJejurkar avatar ShreyasJejurkar commented on May 18, 2024

Thanks, @vnbaaij. I will start working on this one-by-one component this upcoming weekend.

from fast-blazor.

vnbaaij avatar vnbaaij commented on May 18, 2024

@ShreyasJejurkar, @EisenbergEffect Maybe we should use this opportunity to also move the c# code out of the .razor files and into .razor.cs files. We can leverage new VS2022 functionality to do this and then manually remove unnecessary using and use file scope namspace.
Once this is done, Shrejas can use the 'insert ///' to let VS insert summary blocks automatically. Makes adding the comments a lot easier.

from fast-blazor.

ShreyasJejurkar avatar ShreyasJejurkar commented on May 18, 2024

@vnbaaij Hmm. Yeh. That would be a good idea to have a separate file for code-behind .razor.cs. Right now the code is small so it's ok, but going forward it can be huge so better to go off with code-behind.
Am totally ok with that approach. 👍

from fast-blazor.

EisenbergEffect avatar EisenbergEffect commented on May 18, 2024

@vnbaaij In order to minimize conflicts, how do we want to order the PRs? Should we get the namespace/using PR in first, then the update to .razor.cs and then the update to the doc comments? I can probably get the namespace PR merged today. Thoughts?

from fast-blazor.

vnbaaij avatar vnbaaij commented on May 18, 2024

@EisenbergEffect If you canget #126 in first, I'll post another PR to move the code to separate files, update usings, etc in a bit (working on that rn)

from fast-blazor.

EisenbergEffect avatar EisenbergEffect commented on May 18, 2024

#126 is now merged 😄 (I really like the new using and namespace features.)

from fast-blazor.

ShreyasJejurkar avatar ShreyasJejurkar commented on May 18, 2024

@EisenbergEffect yup, that feature is quite good one!

from fast-blazor.

vnbaaij avatar vnbaaij commented on May 18, 2024

@EisenbergEffect #138 is ready for merging the changes mentioned above

from fast-blazor.

vnbaaij avatar vnbaaij commented on May 18, 2024

Closed with #188

from fast-blazor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.