Git Product home page Git Product logo

Comments (3)

stonstad avatar stonstad commented on May 17, 2024

I don't get this behavior with the samples provided so I am going to assume this is user error. Thank you!

from directxtk.

walbourn avatar walbourn commented on May 17, 2024

This condition is in PlatformHeaders.h which in the src directory rather than the inc directory. As such, it's intended use is as an internal implementation header. You are certainly free to use it directly in applications, but I do make slightly different assumptions.

The reason you are getting this error is mostly likely because _WIN32_WINNT_WIN10 is not defined, which means it defaults to 0 so the expression is evaluated to true.

I know the problem is not because WINAPI_FAMILY is not defined or it is set to WINAPI_FAMILY_DESKTOP_APP because VirtualAlloc is in the desktop partition so you would not be getting a compiler error. If you were building your Windows Store app with that setting, it would compile but it would fail to pass WACK validation.

This is one of the challenges of writing code that compiles with a broad range of toolsets & SDKs. The Windows 10 SDK is the only place that _WIN32_WINNT_WIN10 is defined by the standard headers, so contexts where the Windows 8.0, Windows 8.1 SDK, or Xbox One XDK are used won't have it defined. A similar issue happens with _WIN32_WINNT_WINBLUE not being defined in the Windows 8.0 SDK--I don't actually have any 8.0 vs. 8.1 differences in any of my GitHub libraries. To solve this generally, I have two solutions based on internal vs. public use.

In public headers (i.e. those in Inc) I explicitly use the version number rather than symbol name :

#if (_WIN32_WINNT >= 0x0A00 /*_WIN32_WINNT_WIN10*/)

Internally, I have the library's pch.h define _WIN32_WINNT_WIN10 if it is not already defined. This allows me to use the more human readable symbol in both .h and .cpp files in the Src folder.

#if (_WIN32_WINNT >= _WIN32_WINNT_WIN10)

I guess the real question is: What in the PlatformHelpers.h do you use in your code that I should put into a public header instead of an internal one?

As a short-term fix, just add the following somewhere before you include PlatformHelpers.h:

#ifndef _WIN32_WINNT_WIN10
#define _WIN32_WINNT_WIN10 0x0A00
#endif

See Dual-use Coding Techniques for Games

from directxtk.

stonstad avatar stonstad commented on May 17, 2024

Thank you Chuck! Your reply is very insightful and helps me better understand DirectXTK. It is such a clean, well thought out library.

from directxtk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.