PrivilegeEscalation marks nodes as owned, but doesn't reward agent with node value about cyberbattlesim HOT 5 CLOSED

@forrestmckee You can cherry pick the fix from this branch:

https://github.com/microsoft/CyberBattleSim/tree/wiblum/71

It will need some more testing before merging into the main branch, but I've verified that it fixes the problem on your repro notebook. Let me know if that works for you.

Sorry for the delay.
Yes, this fixed the issue for me. Thanks!

from cyberbattlesim.

That would not be a correct behavior. The agent should be rewarded the node value no matter how it got access to it (either via a remote vulnerability or an authenticated connection). Note that it only gets the reward the first time it gets access to it, subsequent attempts to own a node that's already owned by the attacker yield no reward.
We can take a look at it if you have a repro to share.

from cyberbattlesim.

@blumu I've created a quick notebook example that demonstrates what I'm talking about.

Find the environment here

from cyberbattlesim.

Thank you for sharing the repro! So that's indeed a bug. The code that's handling remote exploits does not include the value of the node in the returned reward, it only accounts for discovered nodes:

We should add the value of any owned node, just like we do for the connect action:

from cyberbattlesim.

@forrestmckee You can cherry pick the fix from this branch:

https://github.com/microsoft/CyberBattleSim/tree/wiblum/71

It will need some more testing before merging into the main branch, but I've verified that it fixes the problem on your repro notebook. Let me know if that works for you.

from cyberbattlesim.