environment_generation.py not working properly about cyberbattlesim HOT 9 CLOSED

I could repro but I had to first fix another bug in environment_generation.py where the agent was not installed on any node of the graph:

e287436#diff-d01efcd79fb6d8316931c9a4f8a9578bc9908c4c69f2c613e606db2ebff3944f

Ouch, my bad. Forgot to mention that :-D

I'll get to test it on Monday.

from cyberbattlesim.

Temporarily fixed by replacing

        precondition=model.Precondition(f"Linux&(~({ADMINTAG}&{ADMINTAG}))"),

from cyberbattlesim.

@jaromiru I cannot repro. Could you confirm which version of boolean.py you have installed?
Here is what I have:

~/CyberBattleSim_public$ pip freeze | grep bool
boolean.py==3.8

Repro:

from cyberbattle.simulation.environment_generation import create_random_environment
import cyberbattle.simulation.commandcontrol as commandcontrol

env = create_random_environment('test', 10)
c2 = commandcontrol.CommandControl(env)
c2.print_all_attacks()

Output:

Empty DataFrame
Columns: []
Index: []

from cyberbattlesim.

That's weird. I have boolean.py==3.8. The error is present. When I fix it with the fix above, the output looks like:

  id status                                         properties                                  local_attacks  remote_attacks
0  5  owned  [Win7, PortSMBOpen, PortRDPOpen, DomainJoined,...  [UACME55, UACME52, UACME43, UACME61, UACME45]  [RDPBF, SMBBF]

Not an empty DataFrame.

Are you sure the import from cyberbattle.simulation.environment_generation import create_random_environment is importing from your ~/CyberBattleSim_public and not from somewhere else, maybe previously installed with pip install .?

from cyberbattlesim.

Yes the import is loading from my source directory:

> print(commandcontrol.__file__)
/home/azureuser/CyberBattleSim_public/cyberbattle/simulation/commandcontrol.py

I am also using Python version 3.8.9, not sure if this matters. I'll keep trying to get a repro.

from cyberbattlesim.

The problem is definitely within the boolean library.

import boolean

ALGEBRA = boolean.BooleanAlgebra()
ALGEBRA.parse('1&~1').simplify() # OK

ALGEBRA.TRUE.dual = type(ALGEBRA.FALSE)
ALGEBRA.FALSE.dual = type(ALGEBRA.TRUE)
ALGEBRA.parse('1&~1').simplify() # Exception

$ pip freeze | grep boolean
boolean.py==3.8

$ python -V
Python 3.8.10

from cyberbattlesim.

I could repro but I had to first fix another bug in environment_generation.py where the agent was not installed on any node of the graph:

e287436#diff-d01efcd79fb6d8316931c9a4f8a9578bc9908c4c69f2c613e606db2ebff3944f

from cyberbattlesim.

@jaromiru The main branch of the boolean.py package has an alternative fix for this bug. It's not yet released on PyPI though:
https://github.com/bastikr/boolean.py/pull/100/files

from cyberbattlesim.

@jaromiru I have just verified that the fix in branch master of boolean.py resolves the issue. You do need to remove the other workaround from actions.py and model.py otherwise you'll still get the exception. Since the fix is not release yet on PyPi it needs to be installed from github with:

pip install boolean.py@git+https://github.com/bastikr/boolean.py/@master#egg=numpy_stubs

I'll send a PR with a fix soon.

from cyberbattlesim.