SafeHandle overload should be generated for functions with `out` parameters about cswin32 HOT 5 OPEN

Shouldn't every method that includes out parameters generate SafeHandle derived types?

from cswin32.

Probably. But I'm not sure I understand the question. Already our SafeHandle overloads return derived types and accept the base type. The out parameter signatures should follow the return type precedent by producing the derived type.

from cswin32.

One method coming from the top of my head that does not contain SafeHandle derivative types is GetBuffer from IAudioCaptureClient, with the method being like this:

unsafe void GetBuffer(byte** ppData, out uint pNumFramesToRead, out uint pdwFlags, [Optional] ulong* pu64DevicePosition, [Optional] ulong* pu64QPCPosition);

and its extension method:

internal static unsafe void GetBuffer(this winmdroot.Media.Audio.IAudioCaptureClient @this, out byte* ppData, out uint pNumFramesToRead, out uint pdwFlags, ulong* pu64DevicePosition, ulong* pu64QPCPosition)
{
    fixed (byte** ppDataLocal = &ppData)
    {
        @this.GetBuffer(ppDataLocal, out pNumFramesToRead, out pdwFlags, pu64DevicePosition, pu64QPCPosition);
    }
}

Couldn't the extension method be like this instead? (pu64DevicePosition and pu64QPCPosition can stay as pointers too)

internal static void GetBuffer(this winmdroot.Media.Audio.IAudioCaptureClient @this, out SafeHandle ppData, out uint pNumFramesToRead, out uint pdwFlags, in ulong pu64DevicePosition, in ulong pu64QPCPosition)

from cswin32.

No.

I'm afraid we can't turn byte** parameter types into SafeHandle, as that requires a strongly-typed struct (or typedef in C) so that the metadata can describe what method can be used to release the native resource.

I also don't understand why you would define the last two parameters as in ulong instead of out ulong, considering the direction of data flow as documented for the method.

from cswin32.

I understand. Although it is unfortunate not being able to have SafeHandle there.

I also don't understand why you would define the last two parameters as in ulong instead of out ulong, considering the direction of data flow as documented for the method.

Oops! My bad. I wrote that comment late at evening before going to sleep haha.

from cswin32.