Follow calls to external batch scripts about cmd-call-graph HOT 4 OPEN

Some additional thoughts..

regarding points above
1 - We could add an optional parameter to follow the external calls along with the depth argument (default behavior would be as it is today and only parse the starting file).
2 - We could look to check if the external call script exists in the sub-graph first, so that we don't try to parse through it again unnecessarily
3 - For calls to other programs ('non batch' scripts), currently it's represented as 'x # of external calls.. we could represent a node for each with a reference to the name of the item being called
4 - Visually representing as a rectangle would be great
5 - Limiting the set of files to expand is a nice optional argument also

also attached a potential mockup

from cmd-call-graph.

Thanks @cmg-src for volunteering to take this on!

I like the mock-up! I had another idea as well: to have a rectangle enclose all the nodes of the external script, but I'm not sure how easy it is to do in graphviz.

Also, since it's just aesthetics at that point, we can definitely go with whatever works for you first and then maybe iterate.

Thanks again!

from cmd-call-graph.

Did some research on the idea of to have a rectangle enclose all the nodes of the external script, but I'm not sure how easy it is to do in graphviz.

It looks like this could be handled with subgraph 'clusters' .. [https://graphviz.org/Gallery/directed/cluster.html]
I did some prototyping by manually modifying an existing .dot I had from my testing and while it's do-able, graphically it gets busy, and also in terms of rendering logic, the output appears to need to be in a specific order to group the items of the subgraph within that element.

from cmd-call-graph.

The cluster is exactly what I had in mind, but if you think it becomes too busy let's stick to the design you have with the folder shape. Thanks!

from cmd-call-graph.