ClrMD should stop using HResult as a PInvoke return about clrmd HOT 4 CLOSED

@t-mustafin I have completed the work in ClrMD to stop using HResult as a return from PInvoke. We still use it inside the library itself, but that shouldn't cause problems.

Can you please sync the repository this week and test this out by using ClrMD on x86 Linux? Unfortunately SOS won't work until CLR Diagnostics has a chance to update SOS, but it should be straight forward to run something like this and see if it blows up:

using DataTarget dt = DataTarget.LoadDump("/path/to/coredump");
using ClrRuntime runtime = dt.ClrVersions.Single().CreateRuntime();
runtime.Heap.EnumerateObjects.ToArray();

I would check it next week.

from clrmd.

Yes, SOS uses HResult in pinvoke/reverse pinvoke sigatures of its own. I created dotnet/diagnostics#3101 to track the SOS work.

from clrmd.

@t-mustafin I have completed the work in ClrMD to stop using HResult as a return from PInvoke. We still use it inside the library itself, but that shouldn't cause problems.

Can you please sync the repository this week and test this out by using ClrMD on x86 Linux? Unfortunately SOS won't work until CLR Diagnostics has a chance to update SOS, but it should be straight forward to run something like this and see if it blows up:

using DataTarget dt = DataTarget.LoadDump("/path/to/coredump");
using ClrRuntime runtime = dt.ClrVersions.Single().CreateRuntime();
runtime.Heap.EnumerateObjects.ToArray();

from clrmd.

This changes + patch to diagnostics work for me.

from clrmd.