Git Product home page Git Product logo

Comments (7)

yantang-msft avatar yantang-msft commented on June 1, 2024

@lindgrend, most likely it's because the latest AppInsights sdk switched to W3C correlation header, which is not compatible with the correlation protocol in this SDK.
And there is currently no plan on supporting the new protocol for this SDK, so unfortunately, you'll have to choose between one of them.

from applicationinsights-servicefabric.

lindgrend avatar lindgrend commented on June 1, 2024

Am I understanding it correctly that it could be solved by upgrading Service fabric and would that include going to the next major release then?

from applicationinsights-servicefabric.

yantang-msft avatar yantang-msft commented on June 1, 2024

It's correct it can be solved by implementing the new correlation protocol.
However, this repo is currently in maintenance mode only for bug fixes, there is no plan for next major release. :(

from applicationinsights-servicefabric.

DHoefakker avatar DHoefakker commented on June 1, 2024

@yantang-msft I hop on this issue based on a issue I encounter (https://stackoverflow.com/questions/66011506/applicationinsights-end-2-end-breaks-on-servicefabric-apigateway) which looks like this issue.

Could you clarify a thing
==> However, this repo is currently in maintenance mode only for bug fixes, there is no plan for next major release. :( <==

Does this mean there are no updates coming for ApplicationInsights for ServiceFabric? Because the documentation states that "The correlation HTTP protocol, also called Request-Id, is being deprecated".

What's the best way forward? Forcing it to the "old" correlation protocol?

Hope my question is clear, maybe I misunderstood it a bit ;-)

from applicationinsights-servicefabric.

yantang-msft avatar yantang-msft commented on June 1, 2024

@DHoefakker I at one time saw there is a way to force using Request-Id in the doc, but last time I checked the doc again, I don't see it anymore. @cijothomas do you know how to enforce Request-Id protocol for the .net SDK?

from applicationinsights-servicefabric.

cijothomas avatar cijothomas commented on June 1, 2024

@yantang-msft I believe ApplicationInsights still does request-id propagation along with traceparent. It would respect the ActivityID format set by the user. So one can set ActivityIDformat to legacy one like below. (somewhere in app startup)

Activity.DefaultIdFormat = ActivityIdFormat.Hierrachical;
Activity.ForceDefaultIdFormat = true;

If this doesn't work, please open an issue in the applicaiton insights repo.

from applicationinsights-servicefabric.

DHoefakker avatar DHoefakker commented on June 1, 2024

@cijothomas @yantang-msft Yes, setting the ActivityIDFormat did the trick 🥳

Beside that i am wondering does this mean there are no updates coming for ApplicationInsights for ServiceFabric? Or is it related to .net? Are you now focussing on .net core / .net 5, and maintaining only the .net < 4.x version ?

from applicationinsights-servicefabric.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.