Comments (6)
Please allow me to discuss internally! I will get back to you soon!
from alappextensions.
OK, needed to make sure I got that right. So if the plan is to increase the URL field from 250 to 2048, I approve! You can go ahead and make the change.
The solution you describe would be the right one! Given this is a log table, I could be tempted to ask for a breaking change exception, but it wouldn't be the "right" solution... the table is public and we hence must deprecate the old field, create a new one, copy the data, keep them in sync... Again given it's a log, you could consider if it's OK to truncate the URL and put it into the old field for backwards compatibility. By the book, the logs wouldn't support longer URLs until the old field is deprecated "removed" in 3 releases from now - but usually people cannot wait that long 😉
Anyway, looking forward to what you come up with!
from alappextensions.
Sounds fair to present a clear error message in this case. Approved.
from alappextensions.
As the logging happens after the request has been sent (to an external system) it seems to me too late to raise an error. Considering that I do not see a way to raise the error earlier in the pipeline without making significant changes to the current design, as the HttpRequest object is passed by reference into the (customized) interface implementation of the Send procedure. I assume this would need a more specific scope to move forward with a PR.
As we often face (REST-style) APIs with URLs longer than 250 characters (e.g. due to Guids as entity Ids, et cetera) it would make sense (in our teams opinion) to allow for longer URL paths as a more general solution. To expand the "E-Document Integration Log" URL it would be needed to implement a new field (e.g. "Request URL" or "API URL", change all references to the "old" URL field and mark the old field for pending obsoletion. Since this is obviously a more significant change, I will also not move forward without an approval for this scope.
If we get some guidance which direction (or even a simpler solution) should be implemented, we are happy to move forward with a PR in a timely manner.
from alappextensions.
We agree that a 250 char limit on URLs is sub-optimal and we would be open for improvements here 😊 As you know, the maximum length of a Text field in the database is 2048 characters. Would that suffice? Or are you looking for even longer strings?
from alappextensions.
As written in the original post (Additional context), our team believes that a limit of 2048 characters is an expected limit in the context of Business Central and, at best, no one will notice this limit in the future.
from alappextensions.
Related Issues (20)
- Add parameter at function OnModifyOnBeforeTestCheckPrinted on table "Gen. journal Line"
- Control error pop up at function UnApplyVendorInvoices on codeunit "CheckManagement"
- Missing Vendor Payment Tolerance Event
- Payment Max Tolerance Events
- [Event Request] add a new parameter to the publisher OnTransferFieldData of coudeunit 5336 "Integration Record Synch."
- [Bug]: Replace IsSaaS usage with IsSaaSInfrasturcture in codeunit 6364 "Pagero Auth."
- [Event Request] Codeunit 1255 "Match Bank Payments" Fix OnFindMatchingEntriesOnBeforeFindFirst parameters
- table 5900 "Service Header" SetHideValidationDialog
- codeunit 6620 "Copy Document Mgt." - Event OnBeforeUpdateVendLedgEntry - Add Parameters FromDocType, FromDocNo
- [Event Request] Codeunit 7201 "CDS Integration Impl." - GetOwningTeamName
- [Extensibility] Make variable DeleteIsBlocked protected in Page "Item Tracking Lines"
- Event Update: Add ShowDialog in OnAfterBankDepositPost event in codeunit 1690 "Bank Deposit-Post"
- [Event Request] Purchase Header - Validate Buy-from Vendor No. check Registered
- [Bug]: Unable to create and edit Intrastat Report Setup
- Codeunit 10752 "SII Doc. Upload Management" : Add event OnInvokeBatchSoapRequestOnBeforeGetCertificate
- [Change Request] codeunit 5624 "Cancel FA Ledger Entries"
- [Change Request] codeunit 5624 "Cancel FA Ledger Entries"
- [Change Request] page 1020 "Job G/L Journal"
- [Event Request] T38 "Purchase Header" - procedure OnValidate() - field "Buy-from Vendor No."
- [Change Request] table 38 "Purchase Header"
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from alappextensions.