Comments (4)
krdash
commented on April 28, 2024
Hi Lars @larshp - Thanks for your feedback. we are looking into it and we would clean up and commit the code changes as suggested by you. Thanks, Krishna
from abap-sdk-for-azure.
vikasbansal2022
commented on April 28, 2024
Hi @larshp - We updated the Master Version for AZURE ABAP GIT. Can you please let us know if we can close this issue.
Regards,
Vikas
from abap-sdk-for-azure.
larshp
commented on April 28, 2024
up to 86 occurrences, https://abaplint.app/stats/microsoft/ABAP-SDK-for-Azure/disabled_rules
anyhow, I do recommend taking a look at the recommendations in https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md, and work in a direction with more clean code.
Eg. last week there were zero findings of https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#omit-the-optional-keyword-exporting, now the number is up to 36, as the rule has been disabled
anyhow, feel free to close the issue, if the development team prefers having commented code in the codebase, https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#delete-code-instead-of-commenting-it
./src/zadf_demo/zadf_demo_azure_graph.prog.abap[93, 1] - Commented code (commented_code) [E]
./src/zadf/zadf_graph/zcl_adf_service_graph.clas.abap[61, 1] - Commented code (commented_code) [E]
./src/zadf/zadf_sec/zcl_adf_manage_access_keys.clas.abap[143, 1] - Commented code (commented_code) [E]
./src/zadf/zadf_sec/zcl_adf_manage_access_keys.clas.abap[253, 1] - Commented code (commented_code) [E]
./src/zadf/zadf_sec/zcl_adf_manage_access_keys.clas.testclasses.abap[86, 1] - Commented code (commented_code) [E]
./src/zadf/zadf_sec/zcl_adf_manage_access_keys.clas.testclasses.abap[108, 1] - Commented code (commented_code) [E]
./src/zadf/zadf_sec/zcl_adf_manage_access_keys.clas.testclasses.abap[124, 1] - Commented code (commented_code) [E]
./src/zadf/zadf_sec/zcl_adf_manage_access_keys.clas.testclasses.abap[141, 1] - Commented code (commented_code) [E]
./src/zadf/zadf_sec/zcl_adf_manage_access_keys.clas.testclasses.abap[158, 1] - Commented code (commented_code) [E]
./src/zadf/zadf_sec/zcl_adf_manage_access_keys.clas.testclasses.abap[173, 1] - Commented code (commented_code) [E]
./src/zadf/zadf_sec/zcl_adf_manage_access_keys.clas.testclasses.abap[188, 1] - Commented code (commented_code) [E]
./src/zadf/zadf_sec/zcl_adf_manage_access_keys.clas.testclasses.abap[233, 1] - Commented code (commented_code) [E]
./src/zadf/zadf_sec/zcl_adf_manage_access_keys.clas.testclasses.abap[249, 1] - Commented code (commented_code) [E]
./src/zadf/zadf_service_blob/zcl_adf_service_blob.clas.abap[468, 1] - Commented code (commented_code) [E]
./src/zadf/zadf_shma/zcl_adf_shma_root.clas.abap[76, 1] - Commented code (commented_code) [E]
./src/zadf/zadf_shma/zcl_adf_shma_root.clas.testclasses.abap[91, 1] - Commented code (commented_code) [E]
./src/zadf/zadf_shma/zcl_adf_shma_root.clas.testclasses.abap[101, 1] - Commented code (commented_code) [E]
./src/zadf/zadf_shma/zcl_adf_shma_root.clas.testclasses.abap[116, 1] - Commented code (commented_code) [E]
./src/zadf/zadf_validate_and_adj_keys_cls.prog.abap[47, 1] - Commented code (commented_code) [E]
./src/zadf/zadf_validate_and_adj_keys_cls.prog.abap[50, 1] - Commented code (commented_code) [E]
./src/zadf/zadf_validate_and_adj_keys_cls.prog.abap[62, 1] - Commented code (commented_code) [E]
./src/zadf/zadf_validate_and_adj_keys_cls.prog.abap[198, 1] - Commented code (commented_code) [E]
./src/zadf/zadf_validate_and_adj_keys_cls.prog.abap[280, 1] - Commented code (commented_code) [E]
./src/zadf/zadf_validate_and_adj_keys_cls.prog.abap[283, 1] - Commented code (commented_code) [E]
./src/zadf/zcl_adf_manage_interface_key.clas.testclasses.abap[67, 1] - Commented code (commented_code) [E]
./src/zadf/zcl_adf_manage_interface_key.clas.testclasses.abap[84, 1] - Commented code (commented_code) [E]
./src/zadf/zcl_adf_manage_interface_key.clas.testclasses.abap[92, 1] - Commented code (commented_code) [E]
./src/zadf/zcl_adf_manage_interface_key.clas.testclasses.abap[102, 1] - Commented code (commented_code) [E]
./src/zadf/zcl_adf_manage_interface_key.clas.testclasses.abap[111, 1] - Commented code (commented_code) [E]
./src/zadf/zcl_adf_manage_interface_key.clas.testclasses.abap[121, 1] - Commented code (commented_code) [E]
./src/zadf/zcl_adf_manage_interface_key.clas.testclasses.abap[128, 1] - Commented code (commented_code) [E]
./src/zadf/zcl_adf_manage_interface_key.clas.testclasses.abap[143, 1] - Commented code (commented_code) [E]
./src/zadf/zcl_adf_manage_interface_key.clas.testclasses.abap[158, 1] - Commented code (commented_code) [E]
./src/zadf/zcl_adf_manage_interface_key.clas.testclasses.abap[172, 1] - Commented code (commented_code) [E]
./src/zadf/zcl_adf_service_aad.clas.abap[116, 1] - Commented code (commented_code) [E]
./src/zadf/zcl_adf_service_appinsights.clas.abap[36, 1] - Commented code (commented_code) [E]
./src/zadf/zcl_adf_service_cosmosdb.clas.abap[159, 1] - Commented code (commented_code) [E]
./src/zadf/zcl_adf_service_eventhub.clas.abap[316, 1] - Commented code (commented_code) [E]
./src/zadf/zcl_adf_service_keyvault.clas.abap[85, 1] - Commented code (commented_code) [E]
./src/zadf/zcl_adf_service_reprocess.clas.abap[150, 1] - Commented code (commented_code) [E]
./src/zadf/zcl_adf_service_servicebus.clas.abap[43, 1] - Commented code (commented_code) [E]
./src/zadf/zcl_adf_service_servicebus.clas.abap[83, 1] - Commented code (commented_code) [E]
./src/zadf/zcl_adf_service.clas.abap[867, 1] - Commented code (commented_code) [E]
./src/zadf/zo365_sdk/zcl_o365_service_factory.clas.testclasses.abap[58, 1] - Commented code (commented_code) [E]
./src/zadf/zo365_sdk/zcl_o365_service_factory.clas.testclasses.abap[71, 1] - Commented code (commented_code) [E]
./src/zadf/zo365_sdk/zcl_o365_service_sharepoint.clas.abap[223, 1] - Commented code (commented_code) [E]
./src/zadf/zo365_sdk/zcl_o365_service_sharepoint.clas.testclasses.abap[67, 1] - Commented code (commented_code) [E]
./src/zadf/zo365_sdk/zcl_o365_service_sharepoint.clas.testclasses.abap[88, 1] - Commented code (commented_code) [E]
./src/zadf/zo365_sdk/zcl_o365_service_sharepoint.clas.testclasses.abap[115, 1] - Commented code (commented_code) [E]
./src/zadf/zo365_sdk/zcl_o365_service_sharepoint.clas.testclasses.abap[146, 1] - Commented code (commented_code) [E]
./src/zadf/zo365_sdk/zcl_o365_service_sharepoint.clas.testclasses.abap[169, 1] - Commented code (commented_code) [E]
./src/zadf/zo365_sdk/zcl_o365_service_sharepoint.clas.testclasses.abap[192, 1] - Commented code (commented_code) [E]
./src/zadf/zo365_sdk/zcl_o365_service_sharepoint.clas.testclasses.abap[215, 1] - Commented code (commented_code) [E]
./src/zadf/zo365_sdk/zcl_o365_service_sharepoint.clas.testclasses.abap[230, 1] - Commented code (commented_code) [E]
./src/zadf/zo365_sdk/zcl_o365_service_sharepoint.clas.testclasses.abap[243, 1] - Commented code (commented_code) [E]
./src/zadf/zo365_sdk/zcl_o365_service_sharepoint.clas.testclasses.abap[251, 1] - Commented code (commented_code) [E]
./src/zrest/zcl_rest_framework.clas.abap[513, 1] - Commented code (commented_code) [E]
./src/zrest/zcl_rest_framework.clas.abap[717, 1] - Commented code (commented_code) [E]
./src/zrest/zcl_rest_framework.clas.abap[808, 1] - Commented code (commented_code) [E]
./src/zrest/zcl_rest_framework.clas.abap[816, 1] - Commented code (commented_code) [E]
./src/zrest/zcl_rest_utility_class.clas.abap[913, 1] - Commented code (commented_code) [E]
./src/zrest/zcl_rest_utility_class.clas.abap[959, 1] - Commented code (commented_code) [E]
./src/zrest/zcl_rest_utility_class.clas.abap[1500, 1] - Commented code (commented_code) [E]
./src/zrest/zcl_rest_utility_class.clas.abap[1551, 1] - Commented code (commented_code) [E]
./src/zrest/zrest_call_demo.prog.abap[26, 1] - Commented code (commented_code) [E]
./src/zrest/zrest_call_demo.prog.abap[29, 1] - Commented code (commented_code) [E]
./src/zrest/zrest_call_demo.prog.abap[59, 1] - Commented code (commented_code) [E]
./src/zrest/zrest_call_demo.prog.abap[68, 1] - Commented code (commented_code) [E]
./src/zrest/zrest_monitor_archive_f01.prog.abap[56, 1] - Commented code (commented_code) [E]
./src/zrest/zrest_monitor_archive_f01.prog.abap[90, 1] - Commented code (commented_code) [E]
./src/zrest/zrest_monitor_archive_f01.prog.abap[113, 1] - Commented code (commented_code) [E]
./src/zrest/zrest_monitor_archive_f01.prog.abap[116, 1] - Commented code (commented_code) [E]
./src/zrest/zrest_sched_batch_f01.prog.abap[46, 1] - Commented code (commented_code) [E]
./src/zrest/zrest_scheduler.prog.abap[46, 1] - Commented code (commented_code) [E]
./src/zrest/zrest_scheduler.prog.abap[82, 1] - Commented code (commented_code) [E]
./src/zrest/zrest_scheduler.prog.abap[93, 1] - Commented code (commented_code) [E]
./src/zrest/zrest_screen.prog.abap[682, 1] - Commented code (commented_code) [E]
./src/zrest/zrest_screen.prog.abap[788, 1] - Commented code (commented_code) [E]
./src/zrest/zrest_screen.prog.abap[946, 1] - Commented code (commented_code) [E]
./src/zrest/zrest_screen.prog.abap[949, 1] - Commented code (commented_code) [E]
./src/zrest/zrest_tables_archive_f01.prog.abap[86, 1] - Commented code (commented_code) [E]
./src/zrest/zrest_tables_archive_f01.prog.abap[112, 1] - Commented code (commented_code) [E]
./src/zrest/zrest_tables_archive_f01.prog.abap[191, 1] - Commented code (commented_code) [E]
./src/zrest/zrest_tables_archive_form.prog.abap[564, 1] - Commented code (commented_code) [E]
./src/zssf_con/zcl_ssf_utility.clas.abap[127, 1] - Commented code (commented_code) [E]
./src/zssf_con/zcl_ssf_utility.clas.abap[563, 1] - Commented code (commented_code) [E]
abaplint: 86 issue(s) found, 495 file(s) analyzed
from abap-sdk-for-azure.
vikasbansal2022
commented on April 28, 2024
Thanks, Lars, for the feedback. We will continue to work on ABAP lint checks and make improvements to repo codebase.
from abap-sdk-for-azure.
Related Issues (20)
- This repo is missing important files HOT 1
- Error updating where-used list for CLAS ZCX_ADF_SERVICE_GRAPH HOT 9
- Cosmos fix from PR #93 overridden HOT 3
- Dose ABAP SDK support upload Excel xls file to Blob? HOT 24
- [FEATURE] Alternative deployment option for the SDK without 3rd party dependency HOT 4
- Interface GRAPH not maintained in factory method HOT 2
- Generation ZREST_SCREEN terminated (see long text). Return code ZREST_SCREEN
- Event-Grid - Double json serialization by oref_eventgrid->set_eventgrid_schema HOT 3
- Http version unsupport error when transfer excel from sap to azure blob HOT 3
- How to avoid the problem of duplicate names of some tables caused by importing the Azure SDK. HOT 12
- Link Microsoft AI SDK for SAP HOT 3
- The HTTP version specified is not supported for this operation by the server HOT 2
- Error activating objects HOT 5
- consider renaming AUTH GROUP and AUTH ZGROUP
- Add Possibility to list all blobs in a container HOT 5
- Update repository content to current abapGit format HOT 1
- Import of object ZADF_CONFIGFG failed HOT 9
- Rename default branch to main
- Work with Office365 SharePoint Document Library HOT 9
- Activating ABAP SDK for Azure on SAP Cloud's Steampunk environment fails
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from abap-sdk-for-azure.