Comments (15)
Well, last time I tried, it worked for me.
At a quick glance, the binary looks legit, what did you use as load address?
Also, the MicroPython version you used and the source code is missing to reproduce the issue.
You could also compare the binary to the output of the assembler from espressif.
from micropython-esp32-ulp.
My apologies, here's some more info:
I'm using the current version from micropython.org:
MicroPython v1.10-230-ge0c6dfe90 on 2019-03-24; ESP32 module with ESP32
Code used:
"""
Very basic example showing data exchange main CPU <--> ULP coprocessor.
To show that the ULP is doing something, it just increments the value <data>.
It does that once per ulp timer wakeup (and then the ULP halts until it gets
waked up via the timer again).
The timer is set to a rather long period, so you can watch the data value
incrementing (see loop at the end).
"""
from esp32 import ULP
from machine import mem32
from esp32_ulp.__main__ import src_to_binary
source = """\
data: .long 0
entry: move r3, data # load address of data into r3
ld r2, r3, 0 # load data contents ([r3+0]) into r2
add r2, r2, 1 # increment r2
st r2, r3, 0 # store r2 contents into data ([r3+0])
halt # halt ULP co-prozessor (until it gets waked up again)
"""
binary = src_to_binary(source)
load_addr, entry_addr = 0, 4
ULP_MEM_BASE = 0x50000000
ULP_DATA_MASK = 0xffff # ULP data is only in lower 16 bits
ulp = ULP()
ulp.set_wakeup_period(0, 50000) # use timer0, wakeup after 50.000 cycles
ulp.load_binary(load_addr, binary)
mem32[ULP_MEM_BASE + load_addr] = 0x1000
ulp.run(entry_addr)
while True:
print(hex(mem32[ULP_MEM_BASE + load_addr] & ULP_DATA_MASK))
Going by this I believe the load address is 0
from micropython-esp32-ulp.
Looks like my example code. You didn't modify anything?
from micropython-esp32-ulp.
It is. Trying to walk before I run!
from micropython-esp32-ulp.
I went back to the stable version of Micropython esp32spiram-20190125-v1.10.bin
, and all is good. Apologies for wasting your time.
from micropython-esp32-ulp.
Oh? So they have a regression in daily build? Then you should file a bug on the mp issue tracker.
from micropython-esp32-ulp.
I compiled from source, both HEAD and v1.11 and it has the same problem...
from micropython-esp32-ulp.
@bruno963852 ok, so there seem to be either a incompatible change or a regression in micropython between 1.10 and 1.11.
Can you check the change log and if there is nothing noted, open an issue in the micropython issue tracker?
from micropython-esp32-ulp.
Working on this.
Confirmed: counter.py works on micropython 1.10 release.
Now testing: micropython 1.11-361-g4ba0aff47 (daily build) ...
MicroPython v1.11-361-g4ba0aff47 on 2019-09-29; ESP32 module with ESP32
Type "help()" for more information.
>>> import counter
0000 data
0001 entry
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "counter.py", line 37, in <module>
OSError: 260
So, it does not work with the daily build (and also not with 1.11 as others have found out already).
from micropython-esp32-ulp.
Analyzing the generated binary:
header:
ulp\x00 magic
\x0c\x00 load addr text (= offset of text section from binary start)
\x18\x00 size text
\x00\x00 size data
\x00\x00 size bss
data:
\x00\x00\x00\x00 long 0 (counter value)
entry (code):
\x03\x00\x80r
\x0e\x00\x00\xd0
\x1a\x00\x00r
\x0e\x00\x00h
\x00\x00\x00\xb0
from micropython-esp32-ulp.
Related error codes, got them from esp-idf components/esp_common/src/esp_err_to_name.c:
ERR_TBL_IT(ESP_OK), /* 0 esp_err_t value indicating success (no error) */
ERR_TBL_IT(ESP_ERR_INVALID_SIZE), /* 260 0x104 Invalid size */
ERR_TBL_IT(ESP_ERR_INVALID_ARG), /* 258 0x102 Invalid argument */
ERR_TBL_IT(ESP_ERR_NOT_SUPPORTED), /* 262 0x106 Operation or feature not supported */
So, 260 is ESP_ERR_INVALID_SIZE.
Current esp-idf code:
esp_err_t ulp_load_binary(uint32_t load_addr, const uint8_t* program_binary, size_t program_size)
{
size_t program_size_bytes = program_size * sizeof(uint32_t);
size_t load_addr_bytes = load_addr * sizeof(uint32_t);
if (program_size_bytes < sizeof(ulp_binary_header_t)) {
return ESP_ERR_INVALID_SIZE;
}
if (load_addr_bytes > CONFIG_ESP32_ULP_COPROC_RESERVE_MEM) {
return ESP_ERR_INVALID_ARG;
}
if (load_addr_bytes + program_size_bytes > CONFIG_ESP32_ULP_COPROC_RESERVE_MEM) {
return ESP_ERR_INVALID_SIZE; # XXX is this the problem??? XXX
}
// Make a copy of a header in case program_binary isn't aligned
ulp_binary_header_t header;
memcpy(&header, program_binary, sizeof(header));
if (header.magic != ULP_BINARY_MAGIC_ESP32) {
return ESP_ERR_NOT_SUPPORTED;
}
size_t total_size = (size_t) header.text_offset + (size_t) header.text_size +
(size_t) header.data_size;
ESP_LOGD(TAG, "program_size_bytes: %d total_size: %d offset: %d .text: %d, .data: %d, .bss: %d",
program_size_bytes, total_size, header.text_offset,
header.text_size, header.data_size, header.bss_size);
if (total_size != program_size_bytes) {
return ESP_ERR_INVALID_SIZE; # XXX or is it that? XXX
}
size_t text_data_size = header.text_size + header.data_size;
uint8_t* base = (uint8_t*) RTC_SLOW_MEM;
memcpy(base + load_addr_bytes, program_binary + header.text_offset, text_data_size);
memset(base + load_addr_bytes + text_data_size, 0, header.bss_size);
return ESP_OK;
}
from micropython-esp32-ulp.
I tried to load a similar binary, but with invalid magic, it still errors out with 260 - that means it does not reach the code that checks the magic, so it likely fails at the first check:
if (load_addr_bytes + program_size_bytes > CONFIG_ESP32_ULP_COPROC_RESERVE_MEM) {
return ESP_ERR_INVALID_SIZE;
Suspicion: was the breaking change that micropython > 1.10 was compiled with CONFIG_ESP32_ULP_COPROC_RESERVE_MEM == 0 or so?
from micropython-esp32-ulp.
Reproduction code:
from esp32 import ULP
bin = b'ulp\x00\x0c\x00\x18\x00\x00\x00\x00\x00\x00\x00\x00\x00\x03\x00\x80r\x0e\x00\x00\xd0\x1a\x00\x00r\x0e\x00\x00h\x00\x00\x00\xb0'
assert len(bin) == 36
ulp = ULP()
ulp.load_binary(0, bin)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
OSError: 260
from micropython-esp32-ulp.
Filed an issue there: micropython/micropython#5159
from micropython-esp32-ulp.
upstream bug was fixed / closed, closing here, too.
from micropython-esp32-ulp.
Related Issues (20)
- github + pypi setup > docs?
- "how to release" docs
- Can't get it to run HOT 16
- Thank you so much for great lib, I cannot figure out I2C RD/WR. HOT 8
- LED is not blinking HOT 3
- Still Struggling HOT 37
- Bug: Upper case expressions not supported
- memory problem HOT 3
- Requesting a WAKE example HOT 12
- Request for Clarification of ULP GPIO example HOT 1
- Questiona about GPIO Output (LED) example HOT 3
- Update Actions runner image HOT 1
- Fix build
- Decide how to follow the latest MicroPython HOT 2
- Support ESP32-S2 HOT 8
- ulp rtc clock calibration HOT 2
- Add License/Copyright to all files HOT 7
- interrupt from RTC GPIO
- Update quickstart to use mip instead of upip HOT 7
- Release 1.3.0
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from micropython-esp32-ulp.