possibility `.filter` to accept array glob pattern about micromatch HOT 12 CLOSED

sorry don't know how I missed this!.

Maybe I'm missing something, but why is any of that needed? Couldn't this be achieved by using the main function instead of filter?

micromatch(files, ['*', '!*api*']);

If additional ignore patterns need to be passed, you can do:

micromatch(files, ['*', '!*api*'], {ignore: ['foo/*', '**/bar']);

from micromatch.

Hmmm. Maybe, I'll review it soon, I think I got it.

Actually, it's not an issue, cuz fs-readdir is almost the fastest async/stream out there. ASAP I'll add support for globs and filters using micromatch. :)

Cute avatar btw! 👍

from micromatch.

btw why when benchmark ends not close the std? I mean.. I need to CTRL + C to exit from benchmark.

Can you review benchmarked config, is I missing something?

from micromatch.

I need to CTRL + C to exit from benchmark.

really? hmm, honestly I created benchmarked in like 30 min lol. I just needed something fast, but I should revisit since I use it so much.

Maybe, I'll review it soon, I think I got it.

Actually I might be wrong. It depends... I was thinking about it, maybe it would make the most sense if either a) .isMatch() could take an array of patterns, since that could be used for filtering, or b) we just add multi-pattern functionality like you said... I'll think about it, let me know if you have more suggestions

from micromatch.

really? hmm, honestly I created benchmarked in like 30 min lol. I just needed something fast, but I should revisit since I use it so much.

Yep. idk, but always, maybe I'm in some mistake when implement it, lol.
I just use this

var Suite = require('benchmarked');
var suite = new Suite({
  fixtures: 'fixtures/*.js',
  add: 'code/*.js',
  cwd: __dirname
});

suite.run();

I'll think about it, let me know if you have more suggestions

Agreed. Both are good ideas.

from micromatch.

maybe I'm in some mistake when implement it, lol.

that looks right to me. I think there is a bug.

from micromatch.

Isn't bug label for benchmarked, not here? lol

from micromatch.

lol, that's the problem with off-topic conversations. want to create an issue over there?

from micromatch.

and thanks, I get a little absentminded when I'm working on something.

from micromatch.

want to create an issue over there?

yep yep, no problem, lol, i'll soon

lol, that's the problem with off-topic conversations.

exactly lol

from micromatch.

ok I think I got it. Instead of .filter() how about .every()?

from micromatch.

e.g. "every pattern", not files

from micromatch.