Git Product home page Git Product logo

Comments (7)

paulmillr avatar paulmillr commented on July 3, 2024 4

fixed in v4.0.7: https://github.com/micromatch/micromatch/tree/v4

from micromatch.

jonschlinkert avatar jonschlinkert commented on July 3, 2024 1

PR?

from micromatch.

willitscale avatar willitscale commented on July 3, 2024

How do I put up a PR to fix tags?
The owner of the repo would need to run this:

git push --delete origin 4.0.6
git checkout master
git tag 5.0.0
git push origin tag 5.0.0

from micromatch.

willitscale avatar willitscale commented on July 3, 2024

Here's a PR to correct the versions in master - #258

from micromatch.

jonschlinkert avatar jonschlinkert commented on July 3, 2024

fwiw, this is why I don't like being rushed to make patches on these libs. I'm unfortunately traveling until next weekend, and I have very little time to even look at these issues, much less make updates. I'll need some help from the other maintainers if we want to get this fixed before I get back.

from micromatch.

exussum12 avatar exussum12 commented on July 3, 2024

#248

appears to be the break

from micromatch.

Jason3S avatar Jason3S commented on July 3, 2024

@jonschlinkert,

fwiw, this is why I don't like being rushed to make patches on these libs. I'm unfortunately traveling until next weekend, and I have very little time to even look at these issues, much less make updates. I'll need some help from the other maintainers if we want to get this fixed before I get back.

Wow. Who is able to help you out? Is there someone else that can publish to NPM?

Maybe you have a good suggestion on the next steps. This is my take:

  1. Make a v4 branch based upon 4.0.5.
  2. Bump the version to 4.0.7 on the v4 branch and publish.
  3. From master, bump the version to 5.0.0 and publish.

I believe these steps should address the immediate need.

Cleaning up documentation and the rest can happen later.

from micromatch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.