make patterns the first arg? about micromatch HOT 11 CLOSED

👍

from micromatch.

👍 for the primary API, but you should continue to provide methods that accomplish drop-in equivalency with matching signatures such as mm.multimatch(array, pattern) and mm.minimatch(string, glob)

from micromatch.

Hmm, interesting. So actually add methods to provide parity? like a "minimatch" mode or "multimatch" mode?

from micromatch.

Yeah, well at least just for the main functions. I think it would help people migrate, you'd just drop micromatch. in front of the existing minimatch calls.

from micromatch.

Hm yea, interesting idea, but if someone is going to add micromatch in front of minimatch/multimatch its better to replace them directly with micromatch.isMatch() or/and mm() constructor.

Jon, one idea from yesterday - micromatch.base(string/array) - for getting the base path of glob(s), like base in .expand().tokens.base. Use case - I dont want to use whole expand to only get the base and dont want to require one more dependency - glob-base. Want PR?

from micromatch.

better to replace them directly with micromatch.isMatch() or/and mm() constructor

But now if this change is implemented they'll also have to change arg order. And maybe there will be other differences in the future. The thought behind my suggestion is reducing friction for adoption of this lib as a replacement for those well-established alternatives. The further micromatch deviates from what people are used to, the more friction there will be.

from micromatch.

The further micromatch deviates from what people are used to, the more friction there will be.

Agreed, for this reason I think this is a bad idea. For my own tastes that's kind of a bummer, but it is what it is... closing

from micromatch.

Anyone preferring the other order does already have the option of doing mm.matcher(pattern)(path), which is reasonably close.

from micromatch.

true. and really, if I cared about it so much for my own projects I guess I could wrap it in a function and revers the args lol.

from micromatch.

I did pretty much the same thing here es128/progeny@9706276 when I decided I needed args reversed to improve future cases but still needed to maintain compatibility with the original consumer.

from micromatch.

great minds think alike! except mine thought it like 6 months later... takes me a while sometimes

from micromatch.