Comments (8)
@MichalLytek i believe this may be due to changing the generator's target to es2022
here
i've been playing around locally, and changing that one line creates these two different class definitions in the emitted js:
es2019
let FindManyUserArgs = class FindManyUserArgs {
};
es2022
let FindManyUserArgs = class FindManyUserArgs {
where;
orderBy;
cursor;
take;
skip;
distinct;
};
If I understand correctly, before ES2022, classes had to define properties in the constructor, but since the generated classes in type-graphql don't have constructors, they don't get initialized just by creating an instance of the class (and therefore don't exist unless typegraphql core sets a value for them? guessing here)
from typegraphql-prisma.
I don't see anything that could affect that:
What is your type-graphql
version?
from typegraphql-prisma.
@MichalLytek here's the package.json with all the versions used in my repro
"type-graphql": "2.0.0-beta.4"
but i can also repro with 2.0.0-beta.3
and 2.0.0-beta.2
from typegraphql-prisma.
@MichalLytek it does seem the test snapshots were updated to expect all these undefined values in this commit
from typegraphql-prisma.
but i can also repro with 2.0.0-beta.3 and 2.0.0-beta.2
So this is related to type-graphql
core itself. Will check it.
from typegraphql-prisma.
from typegraphql-prisma.
Closing as fixed by 4c053cc
from typegraphql-prisma.
Thank you @MichalLytek ! Much appreciated.
from typegraphql-prisma.
Related Issues (20)
- Potential memory leak in generation with `@types/lodash` HOT 8
- Code is Generated Incorrectly for `0.27.0` HOT 3
- Omitted fields cannot be initialized HOT 2
- Naming a model "Function" in the schema.prisma crashes the generator HOT 1
- Many-To-Many relationship tables are required to have one non-relational field HOT 1
- TypeScript error in overloading UserResolver's deleteManyUser mutation HOT 2
- Possibly Incorrect Generated Type for `disconnect` in 0.27.1 HOT 8
- emitOnly readResolvers HOT 2
- _count resolver breaks when moving from Prisma 4 to Prisma 5 HOT 1
- Ability to add decorators to _count field
- ability to omit compound unique from typegraphql types HOT 5
- Encountered a JSON parsing error due to an extraneous comma in a TypeGraphQL decorator.
- Syntax error in a particular generated RelationsResolver HOT 1
- Incompatibility with Prisma 5.10.x: import_get_platform.binaryTargets is not iterable HOT 1
- JavaScript heap out of memory HOT 1
- update disconnect fails when disconnecting multiple items HOT 1
- compatibility issue in generated code for prisma v5 not assignable to type HOT 7
- Enforce pagination on generated resolvers HOT 3
- typescript compile throws errors for prisma version over 5.13.0 HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typegraphql-prisma.