Comments (11)
v2.2.3
is being released right now and should address the issue. Give it maybe 30 minutes before you try installing.
from geofirestore-js.
Can you share your package.json dependencies?
from geofirestore-js.
Here's my dependencies.
"dependencies": {
"firebase-admin": "~6.0.0",
"firebase-functions": "^2.0.3",
"@google-cloud/firestore": "^0.17.0",
"geofirestore": "^2.2.1",
},
"devDependencies": {
"tslint": "~5.8.0",
"typescript": "~2.8.3"
},
from geofirestore-js.
Could you try updating your Typescript version to 3.0.3
, and if that doesn't do it, I'd have to ask that you make a sample broken repo so I can test it and see what's happening (and try to push a fix).
from geofirestore-js.
@MichaelSolati I have the same problem, tried to upgrade Typescript as well as tslint, both didn't resolve the issue. You can find an example repo here. Just run npm run lint
in the functions directory, and you'll see the errors. Thanks a lot!
from geofirestore-js.
Thank you @subliminalvoice! Try running this version and see if it fixes it for you
npm i geofirestore/geofirestore-js#fix/lint
I did test it, it seems to work on my end, but I just want to make sure it's good for you. A lot/some of it has to do with your linting rules. So I tried to make some fixes to accommodate more generic linting rules.
There are/were two rules I needed to disable for that file, otherwise it should be good. And if it is I'll launch it as v2.2.3
from geofirestore-js.
@subliminalvoice & @zanecidan have either of you been able to test it out?
from geofirestore-js.
@MichaelSolati haven't had the chance yet, I will try in 2(ish) hours.
from geofirestore-js.
@MichaelSolati the linting works now, great!
I tried to deploy the function and got:
⚠functions[helloWorld(us-central1)]: Deployment error.
Function load error: Code in file lib/index.js can't be loaded.
Did you list all required modules in the package.json dependencies?
Detailed stack trace: Error: Cannot find module 'geofirestore'
at Function.Module._resolveFilename (module.js:476:15)
at Function.Module._load (module.js:424:25)
at Module.require (module.js:504:17)
at require (internal/module.js:20:19)
at Object. (/user_code/lib/index.js:5:24)
at Module._compile (module.js:577:32)
at Object.Module._extensions..js (module.js:586:10)
at Module.load (module.js:494:32)
at tryModuleLoad (module.js:453:12)
at Function.Module._load (module.js:445:3)
but I guess that's due to some GCP internals, it will probably work with a proper version number (2.2.3)
from geofirestore-js.
@subliminalvoice can I see the package.json
? (I have a possible idea, but I just wanna check)
from geofirestore-js.
{
"name": "functions",
"scripts": {
"lint": "tslint --project tsconfig.json",
"build": "tsc",
"serve": "npm run build && firebase serve --only functions",
"shell": "npm run build && firebase functions:shell",
"start": "npm run shell",
"deploy": "firebase deploy --only functions",
"logs": "firebase functions:log"
},
"main": "lib/index.js",
"dependencies": {
"firebase-admin": "^6.0.0",
"firebase-functions": "^2.1.0",
"geofirestore": "github:geofirestore/geofirestore-js#fix/lint"
},
"devDependencies": {
"tslint": "~5.8.0",
"typescript": "~2.8.3"
},
"private": true
}
from geofirestore-js.
Related Issues (20)
- Question - how can I find near documents with each unique radius? HOT 11
- How to write to firestore after geofirestore query HOT 1
- can't write to firestore properly after geofirestore query HOT 1
- StartAt or startAfter support HOT 1
- Query speed HOT 6
- Custom document key HOT 1
- Geoqueries with additional queries? HOT 3
- When querying `near`: `distance` prop is missing when distance is 0 HOT 1
- Support for Firebase JS SDK 9 HOT 9
- customKey not working on read HOT 10
- Pass a custom document ID HOT 1
- Query returning zero results when filtering with where HOT 8
- Support for new firestore 9.x? HOT 1
- runTransaction on a collection (server-side using cloud functions) HOT 1
- firebase geofirestore v9 not working HOT 1
- Bug double removed on a marker HOT 1
- Geofirestore and onSnapshot are giving delayed events - information is not updating properly
- Unsubscribe from GeoQuery.onSnapshot on document deletion HOT 1
- Typescript errors when trying to deploy function HOT 2
- Is there a way to update the criteria of GeoQuery ? Rather then making a new one
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from geofirestore-js.