Comments (4)
Put up an initial PR at #13, let me know what you think!
from zippyjson.
I am curious though: do you control the JSON coming in that can be one of two types for that key? If so, I would recommend using different keys for those types. I also would imagine that it's pretty expensive performance-wise to be throwing exceptions, and that that cost might even dominate the library parsing.
from zippyjson.
Unfortunately we don't control this JSON :(
From a parsing perspective, I do agree that it would probably be strictly faster to use different keys, but performance-wise I'm not completely sure what the hit would be - I was under the impression that because of how Swift error handling works, throwing an error has about the same cost as a return
.
I profiled the performance for our use case with Apple's JSONDecoder
(though haven't run the benchmarks listed in #13 yet) - for the case I profiled we have something like 400,000 objects with a String
property which is converted from either a String
or Number
json type, and about 94% of the CPU time was spent doing bridging to NSDictionary, which makes me hopeful that even with error throwing, ZippyJSON could be significantly faster for our use case.
I'm going to play around with the benchmarks you mentioned in #13 today (thanks for the help there!) and see what effects this error throwing has
from zippyjson.
Done in v1.1.0
from zippyjson.
Related Issues (20)
- `michaeleisel/ZippyJSONCFamily` is missing commit for v1.2.4 HOT 2
- Are there dependencies blocking this library working on Linux? HOT 3
- Not enough bits to represent the passed value HOT 4
- ISO8601 with fractional seconds? HOT 2
- Warning: load of misaligned address HOT 1
- Failed to decode Decimal value HOT 1
- not able to parse an Int value that came as nil HOT 2
- First time of ZippyDecoding seems no improvement of CPU time cost HOT 6
- Not faster than JSONDecoder for specific case HOT 12
- Fix SwiftUI Previews (support arm64 on simulators) HOT 5
- ZippyJSON 1.2.5 depends on JJLISO8601DateFormatter 0.1.4 which does not exist HOT 2
- [ZippyJSONDecoder] Warning: fell back to using Apple's JSONDecoder. HOT 4
- Cannot compile with Xcode 14.1 and 14.2 due to missing JNTErrorInfo and JNTGetErrorInfo HOT 3
- Update release notes with Release Optimisations HOT 2
- Xcode Warning HOT 2
- Reduce size impact of ZippyJSON
- occurs crash on iOS 13.x HOT 11
- Adding Benchmark HOT 3
- Crash during allocation on iOS 13 when app is built with Xcode 15 HOT 5
- Missing required modules HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zippyjson.