When loading state on app init I get data from different app about redux-storage HOT 4 CLOSED

Hi,

this completely depends on the redux-storage-engine you use!

For all engines I've created (for example redux-storage-engine-localstorage) your observation is indeed true.

In the case of redux-storage-engine-localstorage the scoping is only based on the browsers behaviour of localStorage.getItem and localStorage.setItem. So if you host both redux apps under the same domain the keyspace is shared.

With redux-storage-engine-reactnativeasyncstorage the scoping should be based on the appId (I haven't doubled checked this).

So from redux-storage point of view this detail is 100% in the hand of the engine. And for all my engines this behaviour is "by design". 😄

Is there anything wrong with this? Is there a special case why you host two different apps under the same domain? Is there anything that forces you to use a single save-key for multiple apps?

from redux-storage.

Hmm, okey.

I use the redux-storage-engine-reactnativeasyncstorage. And it's no actual problem for me using two different save-keys. This is what I'm doing now. 😄

But it feels wrong that i could get access to the first apps data from the second app. If that would happen with other apps on the users phone it's pretty bad.

If redux-storage-engine-reactnativeasyncstorage scopes on appId, this should not be able to happen?

from redux-storage.

Hm .. redux-storage-engine-reactnativeasyncstorage is simply based on AsyncStorage.getItem and AsyncStorage.setItem (as you can see here). I haven't double checked this but I would assume that react-native keeps the AsyncStorage seperated by app.

If there is something wrong and/or buggy, please report this issue to the react-native team!

from redux-storage.

Okey, will dig a bit deeper in to it. Thanks for the quick replies! 👍 🎉

from redux-storage.