Git Product home page Git Product logo

Comments (5)

mgsloan avatar mgsloan commented on August 17, 2024 4

I think it makes sense to split off a store-test package, which does the following:

  1. Defines utilities for conveniently defining tests for store instances
  2. Has the store test-suite

from store.

Blaisorblade avatar Blaisorblade commented on August 17, 2024

Yes please @mgsloan. Even installing stack requires hspec and related libs. And any client of store has to be built with the same version hspec as store, possibly requiring more recompilation for cabal-install users.

However, this is not so easy because of the use in Data.Store.TH, but that arguably belongs to a smaller store-hspec package. That's probably used in its own testsuite though, making the split a bit harder?
https://github.com/fpco/store/blob/ad2af60f1f65132c2a5b069f938ca25423a4b3e8/src/Data/Store/TH.hs

from store.

sol avatar sol commented on August 17, 2024

@mgsloan As a first step, wouldn't it make sense to just move the test dependencies from top-level to the test suite (haven't looked at it).

from store.

sol avatar sol commented on August 17, 2024

it also provides utilities for checking them via smallcheck and hspec

@mgsloan disregard what I said before, I just read your blog post. Makes sense now.

from store.

mgsloan avatar mgsloan commented on August 17, 2024

Cool! Though, I am willing to revisit this if it helps make store more useful to people.

Could split things out into a store-test package, as described above.

from store.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.