jshint problems. about how-to-sane HOT 8 CLOSED

The reason you are seeing so many of those problems all of a sudden is that I recently added the https://www.npmjs.com/package/sails-hook-eslint by @Globegitter. I haven't yet had a chance to fix them, if you have the time before me, please do!

from how-to-sane.

Please have in mind that, the server/api/blueprint folder is imported into this project from https://github.com/mphasize/sails-generate-ember-blueprints.
So it would make more sense to fix the linting errors as a pull request into that project and re-import, otherwise if I ever have to update the blueprint to a newer version, it would break again...

There is also the issue that sails-generate-ember-blueprints has since upgraded to a new version which I'm not sure if @mphasize has released NPM.

@mphasize can you please advise what you think about this linting and the new version of the blueprint?

EDIT I just looked and it looks like @mphasize released the new blueprints 2 weeks ago. @feitian124 we have to upgrade to them, linting the current ones in how-to-sane is pointless

from how-to-sane.

It seems to me that any code which is imported into the project from blueprints should be excluded from linting. The reason is that everyone has their own coding style and standards, and there's no way that sails-generate-ember-blueprints can conform to all of them. It would be better to either ignore the generated code or change all errors to warnings for those files, in case someone wants to take the time to go back through and change the generated code to the style in their project.

from how-to-sane.

@IanVS I agree. This does pose the question of how we treat the blueprint folder, which is initially generated by another project, but is then likely added on to by the dev...

from how-to-sane.

@mgenev you can easily exclude folders via a .eslintignore in the server folder. In any case, I PRed mphasize/sails-generate-ember-blueprints#32 since these are more or less 'official' sane blueprints it would be nice to have them in the same style.

from how-to-sane.

Ok, I'll do that for the blueprints right now, they do include a little bit of my own code, but it's small and experimental so i'll let it slide.

from how-to-sane.

hi guys, seems there are upstream problems. if so i think we'd better add them to .eslintignore and waiting their updates, or contribute there.

from how-to-sane.

I did. Ignoring blueprints now

from how-to-sane.