Constructor of @Injectable class triggered multiple times about injection-js HOT 6 CLOSED

Would you share the declarations of the services as well?

from injection-js.

Sorry. Seems that I did not describe my issue correctly. I injected the 'DataService' to several Classes.

from injection-js.

Would you provide the entire example so I can reproduce the issue?

from injection-js.

The entire project is too large. So I create a test example here: https://github.com/nxddsnc/injectorTest.
After building this with webpack, I use it like:
let b = new ServiceB(); let c = new ServiceC();
in the constructors of the class ServiceB and ServiceC, I use this to get the ServiceA:
const injector = ReflectiveInjector.resolveAndCreate([ServiceA]); let serviceA = injector.get(ServiceA);
And there's two logs says "service A constructed";

from injection-js.

@nxddsnc you should not create an instance of the ReflectiveInjector inside of the classes' constructors. You should turn this code:

import { Injectable, ReflectiveInjector } from 'injection-js';

@Injectable()
export class ServiceA {
  constructor() {
    console.log('service A constructed');
  }
}

@Injectable()
export class ServiceB {
  constructor() {
    const injector = ReflectiveInjector.resolveAndCreate([ServiceA]);
    let serviceA = injector.get(ServiceA);
  }
}

Into:

import 'reflect-metadata';
import { Injectable, ReflectiveInjector } from 'injection-js';

export class ServiceA {
  constructor() {
    console.log('service A constructed');
  }
}

@Injectable()
export class ServiceB {
  constructor(private serviceA: ServiceA) {}
}

const injector = ReflectiveInjector.resolveAndCreate([ServiceA, ServiceB]);
injector.get(ServiceB);

Notice the following:

• You need reflect-metadata.
• You need to set emitDecoratorMetadata flag in tsconfig.json to `true.
• ServiceB is delegating the instantiation of ServiceA to the ReflectiveInjector. This way ServiceB is not coupled with a specific abstraction (i.e. ReflectiveInjector can pass a subclass of ServiceA), neither with the process of instantiation of ServiceA.

from injection-js.

Understood. Thank you very much!

from injection-js.