Enhancement: aspect be able to alter the arguments and return values about angular-aop HOT 9 CLOSED

This sounds like a very useful idea.
I'll consider its implementation.

from angular-aop.

That would be great

from angular-aop.

I implemented it. I'll be happy if you verify it works.

Now the advices for the before, after and around point-cuts should be able to modify the base function arguments and result.
You will be able to modify the function arguments by changing the args array in the advice:

DemoApp.factory('Logger', function () {
  return function (args) {
    if (args.exception) {
      console.log('%cException: ' + args.exception.message + '. ' + args.method + ' called before proper authorization.',
      'color: red; text-weight: bold; font-size: 1.2em;');
    }

    /* Arguments change */
    args.args = ['New argument', 'One more new argument'];
    /* end of the arguments change */

    var throwData = (args.exception) ? ' and threw: ' + args.exception.message : '';
    console.log('Method: ' + args.method + ', Pointcut: ' + args.when + ', with arguments: ' +
          angular.toJson(args.args) + throwData + ' and resolve data: ' +
          angular.toJson(args.resolveArgs) + ', reject data: ' + angular.toJson(args.rejectArgs));
  };
});

from angular-aop.

Hey Minko, sorry I haven't got back to you sooner. Thanks for implementing this.

This will be very handy indeed. The thing is I still have reservations about the nesting of aspects when you need to apply multiple before, after, etc aspects to the same function(s). It makes debugging your own code very cumbersome - so much so that I think other developers would hate me for introducing AOP!

I was reading Javascript Allonge (very good functional programming book), and came across the same complaint and a solution for the problem proposed by the author in the following implementation of his AOP javascript library: raganwald - YouAreDaChef

Christian

from angular-aop.

I will include improving this framework in my Christmas TODO list.

If you can provide me some use cases, different from the most common ones - logging, authorization, in which you've applied AOP with AngularJS you'll help me a lot!

from angular-aop.

Hi Minko,

Sounds like you're going to have some fun! For me I think the idea of AOP
is great, I just know it can obscure the debugging experience - something
I've said a few times I know ;-)

Anyway here are a few use cases I've either implemented or thought might be
a good fit for AOP:

1. Caching for data services
2. Applying exception handling policy at boundary points / between layers
3. Retry logic, circuit breakers, etc
4. Applying security policies
5. Instrumentation to gather performance statistics

Christian

On Sun, Nov 17, 2013 at 10:04 AM, Minko Gechev [email protected]:

I will include improving this framework in my Christmas TODO list.

If you can provide me some use cases, different from the most common ones

• logging, authorization, in which you've applied AOP with AngularJS you'll
  be very helpful!

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/6#issuecomment-28645761
.

from angular-aop.

Would you mind citing you inside the readme file?

I'm writing a research paper for AOP. I plan to include Angular AOP as JavaScript example so I needed some concrete examples to provide strong arguments for its usage.

Thank you for your response! I haven't considered some of ones you suggested.

from angular-aop.

Of course no problem Minko. Good luck, and looking forward to seeing the
outcome.

C

On Mon, Nov 18, 2013 at 7:37 AM, Minko Gechev [email protected]:

Would you mind citing you inside the readme file?

I'm writing a research paper for AOP. I plan to include Angular AOP as
JavaScript example so I needed some concrete examples to provide strong
arguments for its usage.

Thank you for your response! I haven't considered some of ones you
suggested.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/6#issuecomment-28679727
.

from angular-aop.

Closing this on, it looks like #5

from angular-aop.