Comments (4)
I also have another corner case which I would expect be caught: [email protected].
is actually reported as correct if the typo
check is disabled.
I would expect this to be caught by the regexp validation. It is very annoying as many modern browsers add a period when pressing space twice. I can easily trim the input but that won't remove the trailing dot.
from deep-email-validator.
Checking for spaces is beyond this
The philosophy of this lib is to be really light on validating the format of an email as that notoriously produces a lot of false alarms. Spaces are actually valid I believe in some cases, so I won't be adding that. If you want just regex I recommend validator.
The latter complaint is fair though. This lib should definitely validate that the email should not end with .
.
deep-email-validator/src/regex/regex.ts
Lines 10 to 13 in 7f34d7b
Should add
if (domain.endsWith('.')) {
return 'Must not end with "."'
}
from deep-email-validator.
I agree that you don't want to generate too many false alarms. Though I'd expect that spaces are only before or right after characters such as <> or "" that mark a readable name associated with the actual email.
There certainly should not be any spaces in the actual email part, though I must admit I'm not sure to put that together in a reliable RegExp ;).
from deep-email-validator.
I also have another corner case which I would expect be caught:
[email protected].
is actually reported as correct if thetypo
check is disabled. I would expect this to be caught by the regexp validation. It is very annoying as many modern browsers add a period when pressing space twice. I can easily trim the input but that won't remove the trailing dot.
https://stackoverflow.com/a/49153802
Isn't is a valid domain? So email should also be valid in this case.
from deep-email-validator.
Related Issues (20)
- PR #17, axios version bump did not include a version increase of the deep-email-validator package which is causing issues HOT 1
- Multiple Failures reasons expected but not received
- SMTP Timeout HOT 6
- Do not support some domains, like .cn, .lv, .shop HOT 2
- Option to disallow emails with "+" in it?
- Axios 0.19.2 still being used on NPM HOT 1
- RangeError: Maximum call stack size exceeded HOT 2
- It doesn't work on live server. HOT 4
- Update library with new disposable mail providers HOT 5
- No handling for close event in smtp validation HOT 1
- Please release 0.1.19 HOT 1
- what are the maximum requests per month? HOT 3
- how to import in nodejs? HOT 5
- what is this sender option? HOT 1
- Sowing wrong result even for a valid email
- this returns false for all email addresses HOT 3
- Is there a reason why there is no option for SMTP timeout time?
- Valid emails marked as typo HOT 1
- HELO issues lead to IP Blacklisting
- Support for additional second level domains and domains. gmrit.edu.in is a valid mail domain, but typo module suggesting gmx.com.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deep-email-validator.