Support for 404 about reitit HOT 7 CLOSED

Ok, this is a long time ago, I remember I found a solution to this. See this repo of mine. Hope it helps.

from reitit.

I think it's ok for the Router to have a contract of always returning nil case of error (ring-router is just a normal Router with :compile and :coerce options pre-configured to support http-stuff). The not-found could be handled in the ring-app level, something like:

(def app
  (ring/ring-handler
    (ring/router
      ["/api"
       ["/query/:name" hello-n]
       ["/goodbye"     goodbye]
       ["/hello"       hello]])
    {:not-found not-found-handler}))

Another option would be just to write a guide how to do that in the client-code:

(def app
  (some-fn
    (ring/ring-handler
      (ring/router
        ["/api"
         ["/query/:name" hello-n]
         ["/goodbye" goodbye]
         ["/hello" hello]]))
    not-found-handler))

Need to drink the morning coffee before having an opinion on this.

What do you think?

from reitit.

I added a chapter about the 404 into the ring-docs. Let's start with this and see how things evolve. If the ring-handler has others reasons to have options, this could be put in then.

and thanks, there is btw a great perf improvement about to be released: #44

from reitit.

I'm down with either solution. I like the second one, as it's still simple, and doesn't add to the library.

Also, unrelated, but I keep reading the name "reitit as re-tit". Just thought someone should know!

Thanks for the library, though. Really great work!

from reitit.

That's great! Thanks, Tommi, and thanks for this library!

from reitit.

Thanks for the library Tommi, it's awesome.
I'm also trying to deal with a not-found in the reitit.frontend library where I wrap my clojurescript app and serve views depending on reitit.core.Match object. What's the standard on this if I want to serve a not-found path and still retain path and template data ?

from reitit.

Thanks for the library Tommi, it's awesome. I'm also trying to deal with a not-found in the reitit.frontend library where I wrap my clojurescript app and serve views depending on reitit.core.Match object. What's the standard on this if I want to serve a not-found path and still retain path and template data ?

I'm trying to do that too. have you found a way out?

from reitit.