Git Product home page Git Product logo

Comments (4)

SimonSimCity avatar SimonSimCity commented on May 26, 2024

@lorensr If you open the tests in your browser, this browser will run the tests - not the one you defined in TEST_BROWSER_DRIVER.

When defining TEST_BROWSER_DRIVER you tell the system that you want to run the client-tests in a specific browser - phantomjs in your case. This browser is then starts headless, runs all the tests and writes the report out on the console, which is caught by the browser-runner on the server and printed.

But in your case, you opened the application in - I guess it's chrome? This means that what you see in the console there is the result of the client-tests run in chrome.

Please show the full output of the command you ran on the console which either should include a warning explaining why the tests couldn't run in phantom or the test results.

@aldeed I guess we need a more declarative way of describing this step in the manual: https://github.com/meteortesting/meteor-mocha#run-client-tests-in-any-browser-manually

It should state more clearly that you actually are running the tests in the browser you're opening it in. Maybe we should also add a div if TEST_BROWSER_DRIVER is defined which shows a clear warning stating that you most-likely are currently running the tests in the wrong browser 😅

from meteor-mocha.

aldeed avatar aldeed commented on May 26, 2024

Maybe we should also add a div if TEST_BROWSER_DRIVER is defined which shows a clear warning stating that you most-likely are currently running the tests in the wrong browser

Makes sense to me

from meteor-mocha.

SimonSimCity avatar SimonSimCity commented on May 26, 2024

Since we do not ask the browser to click anywhere on the screen, record screenshots or the-like, this shouldn't have any affect to the outcome of any test, right?

Does this means we could actually always show it if TEST_BROWSER_DRIVER is set?

from meteor-mocha.

SimonSimCity avatar SimonSimCity commented on May 26, 2024

Closing this ticket because Phantom is deprecated (https://github.com/meteortesting/meteor-browser-tests#phantomjs)

from meteor-mocha.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.