Add ability to set mocha's --timeout about meteor-mocha HOT 12 CLOSED

i wonder if this is now possible with the latest updates ? @SimonSimCity any thoughts on this? I keep running into timeouts in my tests on the CI server ;(

from meteor-mocha.

@hexsprite would you have the time to create a PR and prove it working on the client and server? This would help me tons ... I'll be happy to merge it in if I see it working.

Please start by forking https://github.com/meteortesting/meteor-mocha-core and checking it out into the packages folder in your meteor application.

from meteor-mocha.

for server, from what I can see you need to set the timeout within meteor-mocha-core since the global timeout must be set at Mocha instance creation. I'll send a PR to meteor-mocha-core for that. Just tested it and it works well.

from meteor-mocha.

giving it a bit more thought, it might make more sense to change the calling pattern exporting an already instantiated Mocha instance to having something like getMochaInstance([options]) that would let the caller provide those options dynamically.

from meteor-mocha.

here's what is working right now for server: hexsprite/meteor-mocha-core@d623f47

but for client we need to pass those options as they are not known at import time so a getMochaInstance method would work best

from meteor-mocha.

@hexsprite I believe you can set client options just prior to running as is currently done here: https://github.com/meteortesting/meteor-mocha/blob/master/package/client.js#L44-L46

Mocha instance has a timeout method you can call to change it after instantiation.

from meteor-mocha.

Note that there's a PR attempting this, which I think would work fine if just changed to use the timeout method rather than trying to set options.timeout. #33

from meteor-mocha.

So I just realized you can also do this.timeout(5000); inside describe to raise timeout for a particular test suite. I think this is also useful as a workaround.

I tested the #33 by changing it to call mochaInstance.timeout(timeout) but it didn't work.

from meteor-mocha.

I haven't had time to look into the client side yet so if anyone feels called then by all means! :) For server tests my PR to meteor-mocha-core solves it and my CI tests are happy again.

from meteor-mocha.

This one #9?

from meteor-mocha.

@mitar hexsprite/meteor-mocha-core@d623f47

from meteor-mocha.

Fixed, see https://github.com/meteortesting/meteor-mocha#specify-global-timeout

from meteor-mocha.