Comments (4)
Add a ">" to the end of src="foobaz.html"
Original comment by [email protected]
on 13 Jun 2013 at 7:52
from grit-i18n.
There is a bug in the regex!
The .*?> is still not enough to capture the end tag. You may need to check for
both /> and </include>
Original comment by [email protected]
on 28 Jun 2013 at 1:27
from grit-i18n.
Hi robliao@, do you want to upload a code review to codereview.chromium.org
that fixes this? I will be happy to review it and land it for you. You just
run [ gcl upload ] or [ git cl upload ] in your checkout of grit-i18n to upload
the code review.
Original comment by [email protected]
on 28 Jun 2013 at 10:31
from grit-i18n.
I can do that. You'll get the CR mail. I'll send the change around early next
week.
Original comment by [email protected]
on 28 Jun 2013 at 4:45
from grit-i18n.
Related Issues (20)
- Several unit tests failing on Windows HOT 2
- chrome_scaled_image unit tests failing on Windows HOT 1
- chrome_html_unittests failing on Windows HOT 5
- include_unittest fails on Windows
- Couple of policy_templates.writers tests failing with randomized hash values HOT 1
- format/chrome_messages_json.py does not encode multiline messages properly. HOT 1
- Add a trunk/examples directory
- Wrong platform support generated for the policy templates
- target_platform isn't set correctly HOT 4
- Document grit-part (grdp) in https://code.google.com/p/grit-i18n/wiki/GritUsersGuide HOT 2
- Out of date 'examples' link in GritUsersGuide HOT 3
- Document emit_type types. HOT 1
- Warn about duplicate resource inclusion in the PAK files
- Please document the definition of "language code". HOT 2
- grdp file names have to be unique across the whole project. HOT 1
- Grit shouldn't parse HTML tags inside JS comments
- Make available to pip
- Check that duplicate resources at different scale levels aren't in the same pak file HOT 2
- Resource maps silently drop duplicated key field values
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grit-i18n.