Git Product home page Git Product logo

Comments (6)

skalee avatar skalee commented on June 22, 2024

@CAMOBAP wrote in riboseinc/oss-guides#44:

For now, we have two configuration repositories:

Should we create a separate repo for each organization?

As an alternative: we can use 'groups' feature of cimas config and list all repositories in a single place https://github.com/metanorma/metanorma-build-scripts/blob/master/cimas-config/cimas.yml#L850 I think this may be easier to maintain

No idea, really, I haven't worked with Cimas before. The question is if both organizations will have the same settings, especially requirement for Ruby 2.4 support. @opoudjis can you confirm?

from ci.

skalee avatar skalee commented on June 22, 2024

@CAMOBAP wrote in riboseinc/oss-guides#44:

It feels like cimas tool by itself still not friendly, so I would like to ask you if you have a chance to try it please share your feedback:

Well, I must admit that I'm just keeping myself away from that thing, that's all. :)

I seldom work on Metanorma or Relaton, so I don't have much contact with Cimas, I just know that it exists. Gems that I currently maintain are more diverse than these from aforementioned organizations, so I'm not even sure if they could even benefit from Cimas. Also, some of them are used outside of Ribose projects, so adding yet another tool may be contributors-unfriendly.

from ci.

skalee avatar skalee commented on June 22, 2024

@CAMOBAP wrote in riboseinc/oss-guides#44:

One more question in case if I will find some project-specific configuration, should I just drop it or move to some .local.rubocop.yml and include .rubocop.yml in this .local.rubocop.yml ?

Personally I don't see much reason in adding yet another file to that setup which is overcomplicated already. I prefer to keep local overrides in .rubocop.yml.

Also, Rubocop does have the concept of local configuration files. Obviously, you can still have .rubocop.yml like this one:

inherit_from:
  - ...
  - ...
  - .rubocop.local.yml

and this will work locally, provided that .rubocop.local.yml exists. But unfortunately, this will break in Hound because Hound is buggy. Not going into details, our stylebook will take precedence over intended overrides…


But do we really need per project overrides in Metanorma or Relaton? I don't want to answer that, cause I don't know what's required in some helper projects.

from ci.

ronaldtse avatar ronaldtse commented on June 22, 2024

@skalee

But do we really need per project overrides in Metanorma or Relaton? I don't want to answer that, cause I don't know what's required in some helper projects.

Probably not. Can we use a single set of configuration rules across all the orgs/repos?

from ci.

opoudjis avatar opoudjis commented on June 22, 2024

Sorry, I too have not responded. I agree that different configs for different orgs is undesirable. The Ruby 2.4 is a current restriction in the Metanorma stack, but that's the only substantive discrepancy.

from ci.

CAMOBAP avatar CAMOBAP commented on June 22, 2024

cimas 's configuration update to update those files in our metanorma repos

from ci.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.