Git Product home page Git Product logo

Comments (12)

opoudjis avatar opoudjis commented on September 23, 2024 1

Sorry! I've missed:

  • csa (which I've told you off band)
  • un
  • itu

The goal is to get rid of puppeteer completely; the following still use puppeteer:

  • m3d
  • mpfd
  • vsd

@ronaldtse These are surely also candidates for culling.

Alternatively, we can remove PDF support from them. Note that we do not offer PDF support for GB.

from ci.

CAMOBAP avatar CAMOBAP commented on September 23, 2024

Done in 673c133

from ci.

CAMOBAP avatar CAMOBAP commented on September 23, 2024

np @opoudjis thanks for the update, I will update them too

from ci.

CAMOBAP avatar CAMOBAP commented on September 23, 2024

@opoudjis @ronaldtse repos bellow still require puppeteer

Should I update some dependency versions in Gemfile for those repos?

from ci.

ronaldtse avatar ronaldtse commented on September 23, 2024

@CAMOBAP795 can you disable PDF output for m3d, vsd and mpfd? Then we can get rid of puppeteer.

from ci.

CAMOBAP avatar CAMOBAP commented on September 23, 2024

@ronaldtse if we talk in the scope of those PRs which listed above to disable PDF we will need to modify tests, to me it looks like the wrong way to solve.

Because we use cimas, I think we can just postpone update till those processors will really go out of puppeteer

Make sense?

from ci.

ronaldtse avatar ronaldtse commented on September 23, 2024

I think we should comment out PDF for these flavors. No one uses these flavors for PDF functionality.

from ci.

CAMOBAP avatar CAMOBAP commented on September 23, 2024

@ronaldtse could you please check this commit metanorma/metanorma-m3aawg@8811235

Is this what needs to be done?

from ci.

ronaldtse avatar ronaldtse commented on September 23, 2024

@CAMOBAP795 : @opoudjis thoughts?

from ci.

CAMOBAP avatar CAMOBAP commented on September 23, 2024

thanks to @opoudjis, he already reviewed & merge PR's related to this

from ci.

ronaldtse avatar ronaldtse commented on September 23, 2024

Nice, thanks!

from ci.

CAMOBAP avatar CAMOBAP commented on September 23, 2024

I think we can close this one because all repos where we can remove puppeteer updated

If there is still something missed, feel free to reopen this

from ci.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.