Git Product home page Git Product logo

Comments (5)

jpuri avatar jpuri commented on June 2, 2024

Hey team! Please add your planning poker estimate with Zenhub @digiwand @segun @blackdevelopa @seaona

from metamask-extension.

seaona avatar seaona commented on June 2, 2024

Pending to clarify with product, if it really make sense to display the False Positive link, for transactions which failed to be verified - because they are not "false positives" per se.
Since it's a minor issue, we can double-check this with Barbara next week, so we get a confirmation on the expected behaviour here
cc @digiwand

from metamask-extension.

digiwand avatar digiwand commented on June 2, 2024

thanks @seaona! will be on standby

from metamask-extension.

bschorchit avatar bschorchit commented on June 2, 2024

My opinion is we should allow users to report failed transactions as well. I see on the video above that the result type of those show up as benign on the form - could we have it show up as failed? That way blockaid could triage it on their side and differentiate false positives from failed reports.

from metamask-extension.

bschorchit avatar bschorchit commented on June 2, 2024

Oh it seems the result type showing up as benign was a bug on the form side that was already fixed so ignore this part. References: #22536 & slack message

from metamask-extension.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.