Dependencies Issue about json-rpc-engine HOT 7 CLOSED

@NoahZinsmeister this should be merged soon: #17

from json-rpc-engine.

thanks @rekmarks ! you're a champ

from json-rpc-engine.

browserify transforms like babelify need to be deps and not dev deps. However, im considering removing the browserify transform because the babelify/babel version change has been an endless headache

from json-rpc-engine.

i'm pretty sure this package is the one causing some very obscure babel-related build errors in some of my projects.

i'm a bit confused, why can't you just build your source files locally and distribute the built files? having any babel-related package as a dependency is a recipe for disaster imo.

from json-rpc-engine.

@NoahZinsmeister can you link to the relevant errors

from json-rpc-engine.

We have a similar situation, in that we are getting all of babel installed along with our package (zos, a command-line tool) since we indirectly depend on this package. We'd expect babel to be required only as a dev dependency.

Funny thing, we noticed this when core-js (a dependency of Babel) added a post-install message asking for a job for its maintainer.

from json-rpc-engine.

The warnings are thrown any time a package depends on json-rpc-engine without having babel as a dependency, which again should absolutely not be a requirement and is bad practice :).

Code shipped in packages should run without compilation/transpilation/whatever in all environments that the author is interested in supporting (for example, ES5 as described in #3).

warning "@walletconnect/web3-subprovider > web3-provider-engine > eth-json-rpc-filters > json-rpc-engine > @babel/[email protected]" has unmet peer dependency "@babel/core@^7.0.0-0".
warning "@walletconnect/web3-subprovider > web3-provider-engine > eth-json-rpc-filters > json-rpc-engine > [email protected]" has unmet peer dependency "@babel/core@^7.0.0".
warning "@walletconnect/web3-subprovider > web3-provider-engine > eth-json-rpc-filters > json-rpc-engine > @babel/preset-env > @babel/[email protected]" has unmet peer dependency "@babel/core@^7.0.0-0".

from json-rpc-engine.