Comments (12)
This is a change of behaviour between iOS 14 and iOS 15 - the imageBounds
parameter to AnimatedTextAttachment.image(forBounds:textContainer:characterIndex)
is different for the two versions of iOS.
For iOS 14, imageBounds
has a sensible-looking y
value, close to zero. But on iOS 15 runtime, the y
value is close to the height of the view. (20px or whatever).
I can't explain why Β―\_(γ)_/Β―
But I have done an ugly fix to AnimatedAttachmentLabel
:
diff --git a/Views/UIKit/AnimatedAttachmentLabel.swift b/Views/UIKit/AnimatedAttachmentLabel.swift
index 91402d9..c2e30fb 100644
--- a/Views/UIKit/AnimatedAttachmentLabel.swift
+++ b/Views/UIKit/AnimatedAttachmentLabel.swift
@@ -28,7 +28,7 @@ final class AnimatedAttachmentLabel: UILabel, EmojiInsertable {
let imageBounds = animatedAttachment.imageBounds
else { return }
- animatedAttachment.imageView.frame = imageBounds
+ animatedAttachment.imageView.frame = CGRect(x: imageBounds.minX, y: (rect.height - imageBounds.height) / 2, width: imageBounds.width, height: imageBounds.height)
animatedAttachment.imageView.contentMode = .scaleAspectFit
if animatedAttachment.imageView.superview != self {
This change ignores the y-position of the imageBounds
, and instead centers the image vertically in the AnimatedAttachmentLabel
.
(Note: this isn't a good long-term solution, because I think it will break multi-line labels)
from metatext.
Existing in the iOS 15 final versions on iPhone 12 mini:
from metatext.
from metatext.
Any news on this? Still experiencing the same on iOS 15.4.1, iPhone 13 Pro.
from metatext.
Same here.
- Device: iPhone X
- OS: iOS 15.0 (19A5340a)
- App Version: 15.0(4)
from metatext.
Same on iPhone 12 running iOS 15.1.1. I just installed the app and immediately had trouble reading toots because of this.
from metatext.
This is becoming a major blocker to using this app on instances that rely on emotes to convey important information. As a non-iOS developer, is there any way I can help get this fixed?
from metatext.
I think I've narrowed it down to this line:
Specifically the y
value, I think... but I can't for the life of me figure out a better value, or have yet to find a value that aligns correctly.
Scratch that, messing with that value screws up alignment of custom emojis in posts, which as far as I see are aligned correctly, it's just in account names where they're not.
from metatext.
ππ» @prplecake
from metatext.
Confirmed fixed in 1.5.1!
from metatext.
π
from metatext.
fixed in 3e93ced π
from metatext.
Related Issues (20)
- VoiceOver can't activate about 50% of rows in Profile Follower List HOT 1
- VoiceOver "Load More" button in timeline has no default activation HOT 2
- Larger tap radius for action icons HOT 3
- Show highlight on action icon that has been tapped but server response not yet received
- Posting takes 5-30 seconds often HOT 4
- Switching away from app during slow post causes "the network connection was lost" error HOT 2
- Show trending statuses AKA "Explore Posts" HOT 2
- Muting a person doesn't remove their posts that were boosted into my home timeline HOT 2
- Add turn off Image resize option
- Cannot set notification types for second account
- Feed doesnβt refresh HOT 3
- Badge notifications (red circle) not working in Metatext on iOS HOT 1
- People search retains and displays old results inappropriately on second account HOT 2
- 3 Layout constraint warnings with recommended mitigations HOT 1
- Report completion stalls while animating : looks ugly
- Make custom emojis visible to Voice Over HOT 4
- Rare: switching the app in and out frequently can needlessly consume all the budget for API calls HOT 1
- Every Time a new TableViewController is created, it calls the server twice to refresh its viewModel HOT 2
- Content Warning UX Improvements - Increase transparency HOT 1
- URLs only count for 23 characters of mastodon post limit - but metatext counts them all
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from metatext.