Comments (8)
@salsakran do you have the original url you were looking at that this came from?
from metabase.
I think I already mentioned this in the e-mail, but of course it doesn't work. Look at the Query:
{
"database": 7,
"type": "query",
"query": {
"source_table": 269,
"aggregation": [
"rows"
],
"breakout": [
],
"filter": [
"AND",
[
"=",
2073,
1
],
[
null,
2075,
null
]
]
}
}
The stuff I merged into today should give a more useful error message but the fundamental problem here is that the user got a bad download link somehow. The fact that the bad link throws an error is expected behavior 👍
from metabase.
got it. i'm not sure i see what's wrong with the query though. is it because the breakout clause is empty?
from metabase.
No, the second filter
subclause is seriously broken. There's no operator (=
/ !=
/ etc) (pun intended) and the value
is null
too
from metabase.
The QX will remove empty clauses but throw an exception on invalid ones
from metabase.
sure. that makes sense. i'll close this as not a bug then. it's possible there is a frontend bug that is allowing queries to be run with half complete clauses, but we can file that separately.
from metabase.
This was a result of the Timestamp bug Tom fixed earlier this week.
The query builder would try produce broken query dictionaries, and the live
download link would result in that error dictionary.
I'd like to either reopen this bug or create another one to return a useful
error message instead of a json blob with a stack trace in the event of a
bad query dictionary (this goes for any link a user can click on the UI).
Even a 500 page would be better and would at least get logged. Not high
priority, but something to clean up when needing a break from bigger
hairier tasks.
On Thursday, July 9, 2015, Allen Gilliland [email protected] wrote:
—
Reply to this email directly or view it on GitHub
#561 (comment).
from metabase.
filed 2 separate issues to ensure this is fixed long term #569 and #570
from metabase.
Related Issues (20)
- [BE] Suggest a join condition based on the first breakout clause of joined metrics
- Remove extraneous paddings from cartesian charts in React embedding
- Data tables should follow the Mantine theme with proper defaults in React embedding
- Smart scalar should follow the Mantine theme with proper defaults in React embedding
- drop unused components from frontend/src/metabase/dashboard/components/ParametersPopover.jsx and convert to tsx
- When opening a multiseries line chart from dashboard the browser tab name gets the first series name
- Unsupported decorator being added to queries by question builder
- [FE + BE] Do not show aggregation operators for the first stage of metrics-only queries
- Third party cookie investigation for embedding HOT 1
- Add combine column shortcut to the shortcut menu in the chill mode header
- [FE] Clicking "Add aggregation" button should open the expression editor if all source metrics are present in the aggregation clause
- Ability to configure tooltip formatting separately from x/y axis formatting
- When duplicating a dashboard (and the subset of questions inside), create a collection with those questions
- Create test harness based on cloud customer metric usage
- Create new collection for v2 metrics
- Implement metric migration
- Implement question migration for single metric
- Implement question migration for multiple metrics
- Implement downgrade (restoring the original questions)
- Cleanup combo & stacking settings
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from metabase.