Git Product home page Git Product logo

Comments (7)

marcelcorso avatar marcelcorso commented on September 24, 2024

I was thinking we could do like this:

Firing:
NginxStatusHighErrorRate instance=a.messagebird.com
NginxStatusHighErrorRate instance=b.messagebird.com
Resolved:
NginxStatusHighErrorRate instance=c.messagebird.com
NginxStatusHighErrorRate instance=d.messagebird.com

just the alertnames and the instances as a tentative solution

from sachet.

EdSchouten avatar EdSchouten commented on September 24, 2024

We recently upgraded to the latest version of Sachet and also noticed this. I remember I previously sent a pull request to at least show all common labels, which worked very well in our case.

from sachet.

marcelcorso avatar marcelcorso commented on September 24, 2024

Hey @EdSchouten I just found your commit that solved this here
https://github.com/messagebird/sachet/pull/4/files#r99210749

It didn't work for some cases for us at messagebird: when alerts share few labels it also gets hard to understand what is happening.

I did a pull request a few days ago:
https://github.com/messagebird/sachet/compare/better-multiple-alert-msgs

Any comments?

I think we have to put a cap on the amount of alerts to put on a sms. If 100 alerts are firing the message can get pretty big and end up not delivering.

from sachet.

EdSchouten avatar EdSchouten commented on September 24, 2024

What about doing both? Keep the "Firing: ... Resolved: ..." in there, but print the common labels afterwards.

from sachet.

EdSchouten avatar EdSchouten commented on September 24, 2024

Friendly ping. :-)

from sachet.

marcelcorso avatar marcelcorso commented on September 24, 2024

Hi @EdSchouten. Thanks for the ping.
This is also driving us 🔩 internally but we didn't had time to fix it yet.

Again, just printing the common labels is not enough. Different sets of alerts may share nothing and then you would also get not enough information.

What @samwierema thinks about it? Or even @faizann that gets alerts every day :-) ?

from sachet.

marcelcorso avatar marcelcorso commented on September 24, 2024

Hey @EdSchouten. We decided to go with the code on the pull request number 4. Let's all try it out for a bit and see how it goes.

Let us know if you learn something new.

from sachet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.