importlib dependency not taken properly into account (windows) about pygalmesh HOT 9 CLOSED

I checked the recipe.yaml again and noticed we haven't specified importlib_metadata explicitly as a dependency for running (only python and meshio). However, the CI build still installs it see this log for example but it installs both with a hyphen and an underscore, which seems weird to me. After checking, it turns out that one of the builds has been archived (see conda-forge/importlib-metadata-feedstock#2).

@nehaljwani since you seem to be a maintainer of the non-archived package and helped us get onto conda-forge in the last days, do you have any thoughts on this?

from pygalmesh.

Yes, we should add importlib-metadata to the run deps, according to:
https://github.com/nschloe/pygalmesh/blob/master/setup.cfg#L30

We should also add these entry points:

    pygalmesh-volume-from-surface = pygalmesh._cli:volume_from_surface
    pygalmesh-remesh-surface = pygalmesh._cli:remesh_surface
    pygalmesh-from-inr = pygalmesh._cli:inr

from pygalmesh.

Unfortunately, conda differentiates between '-' and '_'.
I had opened an issue long time ago: conda/conda#6762 but nothing has happened yet.

from pygalmesh.

As for your other query regarding the double entry in the build log, that's because of: https://github.com/conda-forge/importlib_metadata-feedstock/blob/df6c8e71fa501b866c663d15637da2824ee41f1d/recipe/meta.yaml#L37-L45

It's harmless. One is just a dependency on the other (as a meta package, no contents)

from pygalmesh.

This now works in the scenario outlined above. Closing, feel free to reopen if I missed something.

from pygalmesh.

It's this library: https://pypi.org/project/importlib-metadata/. Hyphen or underscore shouldn't make a difference.

from pygalmesh.

While we are at it, we should also update the constrains on meshio accordingly.

from pygalmesh.

Still not working with the new build on my windows.

I think I forgot two things in the PR checklist: bumping version number and asking for a re-render. I'll try it now.

from pygalmesh.

made this new PR and merged it to test again. conda-forge/pygalmesh-feedstock#4

from pygalmesh.