Add Layer5 Welcome bot to the Meshery adapter for Linkerd repository about meshery-linkerd HOT 14 CLOSED

Thank you! You've helped me greatly on performing my first contribution and in starting to learn how github and open source works! Thanks for everything and if there are any other beginner issues I'd be glad to contribute more! :D

from meshery-linkerd.

Very cool, @tonyanant. 😄 There's more where that came from. Have you joined the community Slack? If not, here you go - http://slack.layer5.io. Be sure to have a look at this doc.

from meshery-linkerd.

Nice work @tonyanant

from meshery-linkerd.

Hello, can I work on this issue?

from meshery-linkerd.

Yes you can @tonyanant.💪🏽

from meshery-linkerd.

I just performed a pull request regarding this issue. I hope I did everything correctly regarding the pull request and if not I'd love to get some feedback on what I did wrong. Thank you.

from meshery-linkerd.

@tonyanant you did swell job. I actually messed up here. I meant to request that the config.yml file be created in this repository - the Linkerd repository. Will you consider filing another PR against this repo?

from meshery-linkerd.

Sure, but what exactly would you like me to do? I am not sure I understand.

from meshery-linkerd.

@tonyanant the same thing that you did in the Meshery-consul repo, but done in this repo (Meshery-linkerd).

from meshery-linkerd.

@tonyanant feel free to ping me in Slack, if this still doesn't quite make sense. (http://slack.layer5.io)

from meshery-linkerd.

Hi, @tonyanant I think this sums up what @leecalcote is saying. Hope it is clear. 😃

Current Behavior
A welcome bot has been configured to usher in contributors new to this project. Configuration of this welcome bot is missing from the meshery-linkered repository.

Desired Behavior
The config.yml and the welcome folder along with the image inside of it should be copied and placed into the meshery-linkered repository.

from meshery-linkerd.

Ok, I understand what needs to be done and I'll get to it. Thank you! 👍

from meshery-linkerd.

I completed the task and just made the pull request however it did not pass the "static check". Is this because of something I did, or is there some other problem with the code?

from meshery-linkerd.

I doubt it's from your end, @leecalcote will resolve it. Welldon. 🥳

from meshery-linkerd.