Comments (14)
Thank you! You've helped me greatly on performing my first contribution and in starting to learn how github and open source works! Thanks for everything and if there are any other beginner issues I'd be glad to contribute more! :D
from meshery-linkerd.
Very cool, @tonyanant. 😄 There's more where that came from. Have you joined the community Slack? If not, here you go - http://slack.layer5.io. Be sure to have a look at this doc.
from meshery-linkerd.
Nice work @tonyanant
from meshery-linkerd.
Hello, can I work on this issue?
from meshery-linkerd.
Yes you can @tonyanant.💪🏽
from meshery-linkerd.
I just performed a pull request regarding this issue. I hope I did everything correctly regarding the pull request and if not I'd love to get some feedback on what I did wrong. Thank you.
from meshery-linkerd.
@tonyanant you did swell job. I actually messed up here. I meant to request that the config.yml file be created in this repository - the Linkerd repository. Will you consider filing another PR against this repo?
from meshery-linkerd.
Sure, but what exactly would you like me to do? I am not sure I understand.
from meshery-linkerd.
@tonyanant the same thing that you did in the Meshery-consul repo, but done in this repo (Meshery-linkerd).
from meshery-linkerd.
@tonyanant feel free to ping me in Slack, if this still doesn't quite make sense. (http://slack.layer5.io)
from meshery-linkerd.
Hi, @tonyanant I think this sums up what @leecalcote is saying. Hope it is clear. 😃
Current Behavior
A welcome bot has been configured to usher in contributors new to this project. Configuration of this welcome bot is missing from the meshery-linkered
repository.
Desired Behavior
The config.yml and the welcome folder along with the image inside of it should be copied and placed into the meshery-linkered repository.
from meshery-linkerd.
Ok, I understand what needs to be done and I'll get to it. Thank you! 👍
from meshery-linkerd.
I completed the task and just made the pull request however it did not pass the "static check". Is this because of something I did, or is there some other problem with the code?
from meshery-linkerd.
I doubt it's from your end, @leecalcote will resolve it. Welldon. 🥳
from meshery-linkerd.
Related Issues (20)
- Meshery Logo in Dark mode should be white & broken build status image/SVG HOT 2
- Fix Adapter bug causing Linkerd version in e2e tests not being found HOT 1
- Failed to install Linkerd via meshery UI HOT 3
- Deploy from Linkerd's stable channel by default HOT 7
- Ensure that the deployed version is covered by the registered components. HOT 2
- Viz installation fails from Meshery UI HOT 6
- Linkerd error code needs update HOT 2
- Use meshkit's GetRelease function inside of build/config.go to fetch latest version HOT 5
- Normalise Service Mesh Meshmodel model names to SMP enums HOT 2
- Replace the Logo of Layer5 with Meshery in config.yml workflow HOT 7
- CI: The CI needs to be more simple and more clearly HOT 2
- Need for upgrading to v2 of centralised e2e tests HOT 3
- add unit tests for operations.go HOT 3
- Add test coverage for code in this repo. HOT 2
- [Code quality] We need to make sure all the errors from CI are clear HOT 6
- fix the golang-ci lint errors HOT 4
- [bug] Linkerd CRD URL not reachable
- Issue Template Updates for Figma link HOT 3
- [CI]: Remove Ashish (Revolyssup) from reviewers in dependabot yml file HOT 2
- [chore] update Go to 1.21, and update relevant pkgs HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from meshery-linkerd.