Git Product home page Git Product logo

Comments (10)

hinupurthakur avatar hinupurthakur commented on July 19, 2024 1

@leecalcote Yes. I will try to do this and let you kniw if I get stuck somewhere.

from meshery-linkerd.

girishranganathan avatar girishranganathan commented on July 19, 2024 1

@Nupur-thakur yes you are right. You have to uncomment and then go around fixing the errors pointed out by the checks. Feel free to reach out to me if you have any questions.

from meshery-linkerd.

leecalcote avatar leecalcote commented on July 19, 2024

@Nupur-thakur, as a way of familiarizing with the project and expanding your Go skills, would you like to give this issue a try?

from meshery-linkerd.

hinupurthakur avatar hinupurthakur commented on July 19, 2024

Hello @leecalcote I was trying to understand that what exactly I have to do after figuring it out when i checked the ci.yml file of meshery-linkerd I realised that the code for static error checking of Go Code is already there but it has been commented out by somebody.
So do I just need to uncomment and understand the code or I have to find the errors in it if it were there?

from meshery-linkerd.

hinupurthakur avatar hinupurthakur commented on July 19, 2024

@gunjanmimo as you have referenced this issue just a few minutes ago if you could guide me, it will be a great help.

from meshery-linkerd.

kushthedude avatar kushthedude commented on July 19, 2024

Hey, @Nupur-thakur Still working on this issue? If not, may I give it a shot

from meshery-linkerd.

hinupurthakur avatar hinupurthakur commented on July 19, 2024

@kushthedude I am no longer working on this issue as a PR have already merged regarding this Issue by @gunjanmimo

from meshery-linkerd.

kushthedude avatar kushthedude commented on July 19, 2024

from meshery-linkerd.

gunjanmimo avatar gunjanmimo commented on July 19, 2024

there are some more errors, so I need some time. so we should keep this pr open @kushthedude

from meshery-linkerd.

antweiss avatar antweiss commented on July 19, 2024

@gunjanmimo I believe I fixed all the warnings and errors in my latest PR. Please try to rebase on the latest master.

from meshery-linkerd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.