Comments (10)
@leecalcote Yes. I will try to do this and let you kniw if I get stuck somewhere.
from meshery-linkerd.
@Nupur-thakur yes you are right. You have to uncomment and then go around fixing the errors pointed out by the checks. Feel free to reach out to me if you have any questions.
from meshery-linkerd.
@Nupur-thakur, as a way of familiarizing with the project and expanding your Go skills, would you like to give this issue a try?
from meshery-linkerd.
Hello @leecalcote I was trying to understand that what exactly I have to do after figuring it out when i checked the ci.yml file of meshery-linkerd I realised that the code for static error checking of Go Code is already there but it has been commented out by somebody.
So do I just need to uncomment and understand the code or I have to find the errors in it if it were there?
from meshery-linkerd.
@gunjanmimo as you have referenced this issue just a few minutes ago if you could guide me, it will be a great help.
from meshery-linkerd.
Hey, @Nupur-thakur Still working on this issue? If not, may I give it a shot
from meshery-linkerd.
@kushthedude I am no longer working on this issue as a PR have already merged regarding this Issue by @gunjanmimo
from meshery-linkerd.
from meshery-linkerd.
there are some more errors, so I need some time. so we should keep this pr open @kushthedude
from meshery-linkerd.
@gunjanmimo I believe I fixed all the warnings and errors in my latest PR. Please try to rebase on the latest master.
from meshery-linkerd.
Related Issues (20)
- [CI] Makefile: Golang build command returning warning in golang 1.19 HOT 3
- [CI] Update Multi Platform build and Release workflow HOT 8
- [CI] Update e2etests workflow to run on push HOT 1
- Meshery Logo in Dark mode should be white & broken build status image/SVG HOT 2
- Fix Adapter bug causing Linkerd version in e2e tests not being found HOT 1
- Failed to install Linkerd via meshery UI HOT 3
- Deploy from Linkerd's stable channel by default HOT 7
- Ensure that the deployed version is covered by the registered components. HOT 2
- Viz installation fails from Meshery UI HOT 6
- Linkerd error code needs update HOT 2
- Use meshkit's GetRelease function inside of build/config.go to fetch latest version HOT 5
- Normalise Service Mesh Meshmodel model names to SMP enums HOT 2
- Replace the Logo of Layer5 with Meshery in config.yml workflow HOT 7
- CI: The CI needs to be more simple and more clearly HOT 2
- Need for upgrading to v2 of centralised e2e tests HOT 3
- add unit tests for operations.go HOT 3
- Add test coverage for code in this repo. HOT 2
- [Code quality] We need to make sure all the errors from CI are clear HOT 6
- fix the golang-ci lint errors HOT 4
- [bug] Linkerd CRD URL not reachable
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from meshery-linkerd.